Page MenuHomePhabricator

[CMake] Give Python module install command a component name
AbandonedPublic

Authored by xiaobai on Jul 5 2018, 1:39 PM.

Details

Summary

This install command is used to install all the python modules and
python bindings. Currently the only way to install it is this:
cmake -P build/tools/lldb/tools/scripts/cmake_install.cmake
However with my change you should be able to add "lldb-python-bindings" to
LLVM_DISTRIBUTION_COMPONENTS and invoke ninja install-distribution.
Alternatively, you can do something like
`cmake -DCMAKE_INSTALL_COMPONENT="lldb-python-modules" -P
build/cmake_install.cmake` yourself.

Event Timeline

xiaobai created this revision.Jul 5 2018, 1:39 PM
compnerd accepted this revision.Jul 5 2018, 2:50 PM
This revision is now accepted and ready to land.Jul 5 2018, 2:50 PM
xiaobai planned changes to this revision.Jul 5 2018, 3:04 PM

This isn't quite doing what I want yet. I intend on adding an install target.

xiaobai abandoned this revision.Jul 5 2018, 4:50 PM

Gonna take some time to rethink and better understand this.

The install- target is created by add_llvm_install_targets, not by the component. The component is part of CMake itself, and is controlled by the CMAKE_INSTALL_DEFAULT_COMPONENT_NAME.