This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Do not write comments into Preamble PCH
ClosedPublic

Authored by ilya-biryukov on Jul 4 2018, 8:26 AM.

Details

Summary

To avoid wasting time deserializing them on code completion and
further reparses.

We do not use the comments anyway, because we cannot rely on the file
contents staying the same for reparses that reuse the prebuilt
preamble PCH.

Event Timeline

ilya-biryukov created this revision.Jul 4 2018, 8:26 AM
sammccall accepted this revision.Jul 5 2018, 1:01 AM

Very nice!

clangd/ClangdUnit.cpp
327

nit: these are comment *locations* right?
(Relevant because if we were writing the actual comments, we may actually want this on!)

This revision is now accepted and ready to land.Jul 5 2018, 1:01 AM
ilya-biryukov marked an inline comment as done.
  • Fix a comment
This revision was automatically updated to reflect the committed changes.