This is an archive of the discontinued LLVM Phabricator instance.

Differential D48842

[llvm] Document "%T" as deprecated in CommandGuide/lit.rst
ClosedPublic

Authored by kubamracek on Jul 2 2018, 10:33 AM.

Details

Reviewers
• ddunbar
jdenny
Lekensteyn
MatzeB
rnk
Commits
rGa2e0c2462a5e: [llvm] Document "%T" as deprecated in CommandGuide/lit.rst
rL340677: [llvm] Document "%T" as deprecated in CommandGuide/lit.rst

Diff Detail

Event Timeline

kubamracek created this revision.Jul 2 2018, 10:33 AM
jdenny added inline comments.Jul 2 2018, 12:33 PM
docs/CommandGuide/lit.rst
406

I'd prefer "parent directory".

Otherwise, LGTM. I can accept unless you know of someone else who will want to take a look first.

kubamracek updated this revision to Diff 154709.Jul 9 2018, 3:05 PM
jdenny accepted this revision.Jul 10 2018, 7:04 AM
This revision is now accepted and ready to land.Jul 10 2018, 7:04 AM
Closed by commit rL340677: [llvm] Document "%T" as deprecated in CommandGuide/lit.rst (authored by kuba.brecka). · Explain WhyAug 24 2018, 6:29 PM
This revision was automatically updated to reflect the committed changes.
MaskRay mentioned this in D69572: [ELF][test] Change referenceds of %T to %t.dir.Oct 29 2019, 10:32 AM
MaskRay mentioned this in rGdb8dad20b37f: [ELF][test] Change references of %T to %t.dir.Oct 30 2019, 9:24 AM

Revision Contents

PathSize
docs/
CommandGuide/
2 lines

Diff 154709

docs/CommandGuide/lit.rst

Show First 20 Lines • Show All 397 Lines • ▼ Show 20 Lines
========== ============== ========== ==============
Macro Substitution Macro Substitution
========== ============== ========== ==============
%s source path (path to the file currently being run) %s source path (path to the file currently being run)
%S source dir (directory of the file currently being run) %S source dir (directory of the file currently being run)
%p same as %S %p same as %S
%{pathsep} path separator %{pathsep} path separator
%t temporary file name unique to the test %t temporary file name unique to the test
%T temporary directory unique to the test %T parent directory of %t (not unique, deprecated, do not use)
jdennyUnsubmitted
Not Done
ReplyInline Actions

I'd prefer "parent directory".

Otherwise, LGTM. I can accept unless you know of someone else who will want to take a look first.

jdenny: I'd prefer "parent directory". Otherwise, LGTM. I can accept unless you know of someone else…
%% % %% %
========== ============== ========== ==============
Other substitutions are provided that are variations on this base set and Other substitutions are provided that are variations on this base set and
further substitution patterns can be defined by each test module. See the further substitution patterns can be defined by each test module. See the
modules :ref:`local-configuration-files`. modules :ref:`local-configuration-files`.
More detailed information on substitutions can be found in the More detailed information on substitutions can be found in the
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines