Page MenuHomePhabricator

Lekensteyn (Peter Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2015, 2:59 AM (211 w, 2 d)

Recent Activity

Aug 10 2019

Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Thanks for picking this up again. I've left some nitpicks below in a quick review.

Aug 10 2019, 7:56 AM · Restricted Project, Restricted Project
Herald added a project to D56769: Path: enhance prefix mapping: Restricted Project.

Should this be abandoned for D49466?

Aug 10 2019, 7:56 AM · Restricted Project

Jul 15 2019

Lekensteyn committed rGfa52e00c85ce: [Sema] Suppress additional warnings for C's zero initializer (authored by Lekensteyn).
[Sema] Suppress additional warnings for C's zero initializer
Jul 15 2019, 6:16 PM
Lekensteyn committed rL366163: [Sema] Suppress additional warnings for C's zero initializer.
[Sema] Suppress additional warnings for C's zero initializer
Jul 15 2019, 6:13 PM
Lekensteyn closed D61838: [Sema] Suppress additional warnings for C's zero initializer.
Jul 15 2019, 6:13 PM · Restricted Project, Restricted Project
Lekensteyn accepted D61838: [Sema] Suppress additional warnings for C's zero initializer.

Thanks, I'll push once the build and test pass.

Jul 15 2019, 5:10 PM · Restricted Project, Restricted Project
Lekensteyn added a comment to D61838: [Sema] Suppress additional warnings for C's zero initializer.

@al3xtjames I was about to commit this but noticed that some others check whether getInit(0) is NULL or not before proceeding. Should that be done here as well? If not, why?

Jul 15 2019, 3:56 PM · Restricted Project, Restricted Project
Lekensteyn accepted D64773: [ASan] Support `{f}puts(NULL)` on Darwin.

LGTM. Not sure when this was added, but it must have been present since at least Mac OS X 10.7.3:
https://opensource.apple.com/source/Libc/Libc-763.12/stdio/fputs.3.auto.html
https://opensource.apple.com/source/Libc/Libc-763.12/stdio/FreeBSD/fputs.c.patch.auto.html

Jul 15 2019, 3:31 PM · Restricted Project, Restricted Project

Jun 23 2019

Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Hi @dankm, any progress on this feature? The proposed branch off date for Clang 9.0.0 is 18 July 2019: https://lists.llvm.org/pipermail/cfe-dev/2019-June/062628.html

Jun 23 2019, 11:45 AM · Restricted Project, Restricted Project
Lekensteyn added a comment to D61838: [Sema] Suppress additional warnings for C's zero initializer.

@rsmith The latest patch version has addressed your feedback, can you confirm that this is ready to be merged?

Jun 23 2019, 11:43 AM · Restricted Project, Restricted Project

Jun 9 2019

Lekensteyn added a comment to D61838: [Sema] Suppress additional warnings for C's zero initializer.

@rsmith Are you happy with the changes, is it ready to be merged?

Jun 9 2019, 11:28 AM · Restricted Project, Restricted Project

May 20 2019

Lekensteyn accepted D61838: [Sema] Suppress additional warnings for C's zero initializer.

Verified again!

May 20 2019, 10:00 AM · Restricted Project, Restricted Project

May 16 2019

Lekensteyn accepted D61838: [Sema] Suppress additional warnings for C's zero initializer.

Thanks, I have also verified this patch against the above test case.

May 16 2019, 5:27 PM · Restricted Project, Restricted Project
Lekensteyn added a comment to D61838: [Sema] Suppress additional warnings for C's zero initializer.

This looks reasonable to fix the problem at hand, but would it handle nested structures too?

May 16 2019, 2:01 PM · Restricted Project, Restricted Project

Jan 17 2019

Lekensteyn added inline comments to D56769: Path: enhance prefix mapping.
Jan 17 2019, 1:29 PM · Restricted Project

Jan 16 2019

Lekensteyn committed rLLD351396: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
[ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT
Jan 16 2019, 3:34 PM
Lekensteyn committed rL351396: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
[ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT
Jan 16 2019, 3:34 PM
Lekensteyn closed D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
Jan 16 2019, 3:34 PM
Lekensteyn updated the diff for D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.

We should cherrypick this patch to 8.0 branch so that 8.0 will be shipped with this fix included. I'll file a bug and do, so no worries.

Jan 16 2019, 3:22 PM
Lekensteyn added a comment to D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.

Can I backport this to the 8.0 release branch? Are there any special rules for that?

Jan 16 2019, 2:35 PM
Lekensteyn updated the diff for D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.

I mean why don't you move this comment inside if (NextOp == 0xe8) {?

Jan 16 2019, 2:24 PM
Lekensteyn added inline comments to D56769: Path: enhance prefix mapping.
Jan 16 2019, 1:51 PM · Restricted Project
Lekensteyn added inline comments to D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
Jan 16 2019, 11:14 AM
Lekensteyn updated the diff for D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.

Updated coding style as suggested. Only one issue is still open (whether to remove/change the comment in the source file). Thank you for the feedback!

Jan 16 2019, 8:07 AM
Lekensteyn added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jan 16 2019, 7:32 AM · Restricted Project, Restricted Project
Lekensteyn added inline comments to D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
Jan 16 2019, 7:11 AM
Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Changes still look reasonable, but the preceding path (https://reviews.llvm.org/D56769) needs some work.

Jan 16 2019, 6:26 AM · Restricted Project, Restricted Project
Lekensteyn requested changes to D56769: Path: enhance prefix mapping.

This has some broken edge cases. Consider extending the ReplacePathPrefix test in unittests/Support/Path.cpp for the new cases.

Jan 16 2019, 6:17 AM · Restricted Project
Lekensteyn created D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT.
Jan 16 2019, 5:43 AM

Jan 14 2019

Lekensteyn accepted D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_bytes.cc (2932 of 6195)
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_string.cc (2935 of 6195)
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc.cc (2974 of 6195)
PASS: ThreadSanitizer-x86_64 :: sunrpc.cc (5110 of 6195)

So yep, it works. Tested both ways now.

Jan 14 2019, 10:41 AM · Restricted Project
Lekensteyn added a comment to D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.

The direction of this patch looks reasonable to me. Is it worth mentioning the issue (https://github.com/google/sanitizers/issues/974) in the commit message?

Jan 14 2019, 9:38 AM · Restricted Project
Lekensteyn accepted D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Still fine by me, thanks!

Jan 14 2019, 8:25 AM · Restricted Project, Restricted Project

Jan 12 2019

Lekensteyn accepted D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Tests pass here, using it on a large CMake project with a CMAKE_BUILD_TYPE=Debug and c/cxxflags -ffile-prefix-map=$builddir= -ffile-prefix-map=$srcdir/= -fuse-ld=lld successfully strips all traces of $builddir and $srcdir.

Jan 12 2019, 4:52 PM · Restricted Project, Restricted Project

Jan 11 2019

Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Except one thing, it looks reasonable to me. I'll try to run some tests and report back tomorrow.

Jan 11 2019, 4:04 PM · Restricted Project, Restricted Project
Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Could you add more tests to check the error message for bad options (missing =):

Jan 11 2019, 9:55 AM · Restricted Project, Restricted Project
Lekensteyn added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

It would be nice to have this for Clang 8.0, the branch date is within 5 days :)

Jan 11 2019, 7:32 AM · Restricted Project, Restricted Project

Dec 23 2018

Lekensteyn added a comment to D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.

There appears to be other definitions for HAVE_TIRPC_RPC_XDR_H in
lib/sanitizer_common/sanitizer_platform.h
lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc

Dec 23 2018, 3:20 PM · Restricted Project

Dec 19 2018

Lekensteyn committed rL349637: [Object] Deduplicate long archive member names.
[Object] Deduplicate long archive member names
Dec 19 2018, 8:18 AM
Lekensteyn closed D55860: [Object] Deduplicate long archive member names.
Dec 19 2018, 8:18 AM
Lekensteyn updated the diff for D55860: [Object] Deduplicate long archive member names.

Added braces and updated comment. Thanks for the feedback!

Dec 19 2018, 8:13 AM
Lekensteyn added a comment to D55860: [Object] Deduplicate long archive member names.

I'm not intimately familiar with the structure of ar files, but the change looks like it makes sense to me at least. Does MSVC link.exe produce import libraries with deduplicated member names as well?

Dec 19 2018, 2:12 AM

Dec 18 2018

Lekensteyn created D55860: [Object] Deduplicate long archive member names.
Dec 18 2018, 3:30 PM
Lekensteyn changed the visibility for D51759: [llvm] Improve the performance of getSymbols used by ArchiveWriter .
Dec 18 2018, 3:27 PM

Dec 9 2018

Lekensteyn abandoned D54109: [clang-query] continue querying even if files are skipped.

This was addressed by https://reviews.llvm.org/D51183 (without new tests though).

Dec 9 2018, 9:13 AM

Nov 6 2018

Lekensteyn updated the diff for D54109: [clang-query] continue querying even if files are skipped.

Changes:

  • Return 1 (instead of 0) if none of the files could be parsed (and add a test for it)
  • Propagate any error code (like 2 in case of some missing files) from Tool.buildASTs instead of returning 0.
  • Change test to accomodate the change in behavior/output due to https://reviews.llvm.org/D51729 (Thanks to Sam McCall for feedback.)
Nov 6 2018, 5:59 AM
Lekensteyn added a comment to D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files.

I'm not entirely sure what to do here. The old behavior works great in cases where a complete database is available (produced by CMake). The new behavior might work better for clangd (?), but it breaks a use case (see above).

For clangd, but also clang-tidy and clang-query when the user *does* want to use it on files not represented in the CDB. (e.g. stale or headers)
There's indeed a tension here, because the CDB discovery needs to have a default configuration.

Nov 6 2018, 4:54 AM

Nov 5 2018

Lekensteyn added a comment to D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files.

Before this patch, missing compilation database entries resulted in "Skipping .... Compile command not found." which is assumed by the tests in this clang-query patch: https://reviews.llvm.org/D54109

Nov 5 2018, 9:01 AM
Lekensteyn added inline comments to D54109: [clang-query] continue querying even if files are skipped.
Nov 5 2018, 8:42 AM
Lekensteyn created D54109: [clang-query] continue querying even if files are skipped.
Nov 5 2018, 8:40 AM

Oct 1 2018

Lekensteyn added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Oct 1 2018, 1:13 PM · Restricted Project, Restricted Project
Lekensteyn requested changes to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

The functionality looks correct to me, but could you include some tests in test/Driver/ and test/Preprocessor/ just to be sure?
test/Driver/debug-prefix-map.c and test/CodeGen/debug-prefix-map.c could serve as inspiration.

Oct 1 2018, 9:23 AM · Restricted Project, Restricted Project

Jul 20 2018

Lekensteyn added a comment to D48033: [ASAN] fix crash in GetGlobalsForAddress after dlclose.

ping

Jul 20 2018, 9:11 AM · Restricted Project

Jul 9 2018

Lekensteyn added a comment to D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.

This would be the first user of pkg-config here. I am not sure if this would be the best fix. Usually you cannot (easily) recompile libc and override it, but for external libs such as libtirpc this should be more doable (I think).

I don't think libtirpc's include path is expected to be predictable by design. I think it's something distro maintainers have to choose to avoid collision with headers that (used to be) installed by glibc. In any case, I can't think of a better solution than pkg-config here (libtirpc doesn't come with CMake modules).

Jul 9 2018, 7:11 AM · Restricted Project
Lekensteyn added a comment to D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.

Hi, thank you for the patch. First a disclaimer, I am not familiar with this RPC API at all.

Jul 9 2018, 4:41 AM · Restricted Project

Jun 17 2018

Lekensteyn abandoned D48255: [sanitizer] Fix LSAN for 32-bit glibc before 2.27.

Superseded by https://reviews.llvm.org/D48265

Jun 17 2018, 1:54 PM · Restricted Project
Lekensteyn abandoned D48254: [sanitizer] Refactor GNU libc version retrieval.

Superseded by https://reviews.llvm.org/D48265

Jun 17 2018, 1:52 PM · Restricted Project
Lekensteyn accepted D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.

With the three whitespace issues fixed up, LGTM.
(I am also observing that the version check in ThreadDescriptorSize is Linux-only (minus Android), such that the cpp guards !SANITIZER_FREEBSD && !SANITIZER_ANDROID && ... will be broad enough.)

Jun 17 2018, 3:10 AM

Jun 16 2018

Lekensteyn added inline comments to D48255: [sanitizer] Fix LSAN for 32-bit glibc before 2.27.
Jun 16 2018, 9:47 AM · Restricted Project
Lekensteyn updated the diff for D48255: [sanitizer] Fix LSAN for 32-bit glibc before 2.27.

Oops, wrong (unsplit) diff. This is the correct one and depends on D48254.

Jun 16 2018, 3:18 AM · Restricted Project
Lekensteyn created D48255: [sanitizer] Fix LSAN for 32-bit glibc before 2.27.
Jun 16 2018, 3:16 AM · Restricted Project
Lekensteyn created D48254: [sanitizer] Refactor GNU libc version retrieval.
Jun 16 2018, 3:12 AM · Restricted Project
Lekensteyn added inline comments to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Jun 16 2018, 2:04 AM · Restricted Project

Jun 15 2018

Lekensteyn added inline comments to D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Jun 15 2018, 6:17 AM
Lekensteyn added a reviewer for D48213: [DFSAN] fix gethostname test failure for short hostnames: pcc.
Jun 15 2018, 3:56 AM · Restricted Project
Lekensteyn created D48213: [DFSAN] fix gethostname test failure for short hostnames.
Jun 15 2018, 3:36 AM · Restricted Project

Jun 14 2018

Lekensteyn added a comment to D48186: [asan] Move long-object-path.cc test to Linux.

Wait, what happened to compiler-rt/test/asan/TestCases/log-path_test.cc? It should not be removed.

Jun 14 2018, 1:57 PM
Lekensteyn accepted D48189: [llvm] Document "%T" as deprecated in TestingGuide.rst.
Jun 14 2018, 1:24 PM
Lekensteyn added a comment to D48189: [llvm] Document "%T" as deprecated in TestingGuide.rst.

One small comment, LGTM otherwise.

Jun 14 2018, 1:12 PM
Lekensteyn added a comment to D35396: [lit] Remove %T.

Hi, what is the status with this patch? It was referred to by https://reviews.llvm.org/D36495 (which is committed), and there still seem to be a lot of users of %T.

Yes, that's why this one didn't land yet. We need to get rid of all the %T users first.

Jun 14 2018, 12:52 PM
Lekensteyn accepted D48186: [asan] Move long-object-path.cc test to Linux.

Good idea, the workaround was only needed for glibc (which officially supports Linux and Hurd only).

Jun 14 2018, 12:50 PM
Lekensteyn added a comment to D35396: [lit] Remove %T.

Hi, what is the status with this patch? It was referred to by https://reviews.llvm.org/D36495 (which is committed), and there still seem to be a lot of users of %T.

Jun 14 2018, 9:07 AM
Lekensteyn added a comment to D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.

Thanks for the reviews, I fixed both typos in r334719 and disabled the test due to a lit problem on Windows. I'll be looking at supporting glob patterns for commands in general or just the "cd" builtin.

Jun 14 2018, 8:20 AM · Restricted Project
Lekensteyn committed rCRT334719: [ASAN] fix typos and disable long-object-path test for win32.
[ASAN] fix typos and disable long-object-path test for win32
Jun 14 2018, 8:17 AM
Lekensteyn committed rL334719: [ASAN] fix typos and disable long-object-path test for win32.
[ASAN] fix typos and disable long-object-path test for win32
Jun 14 2018, 8:17 AM
Lekensteyn added inline comments to D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
Jun 14 2018, 3:48 AM · Restricted Project
Lekensteyn committed rCRT334703: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
[ASAN] fix startup crash in dlsym for long paths since glibc 2.27
Jun 14 2018, 3:47 AM
Lekensteyn committed rL334703: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
[ASAN] fix startup crash in dlsym for long paths since glibc 2.27
Jun 14 2018, 3:47 AM
Lekensteyn closed D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
Jun 14 2018, 3:47 AM · Restricted Project

Jun 13 2018

Lekensteyn committed rCRT334670: [ASAN] Fix fputs interception for 32-bit macOS.
[ASAN] Fix fputs interception for 32-bit macOS
Jun 13 2018, 4:23 PM
Lekensteyn committed rL334670: [ASAN] Fix fputs interception for 32-bit macOS.
[ASAN] Fix fputs interception for 32-bit macOS
Jun 13 2018, 4:23 PM
Lekensteyn added a comment to D48109: [Timers] Use the pass argument name for JSON keys in time-passes.

FYI, this caused a regression: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/49533/testReport/junit/LLVM/Other/statistic_ll/

Jun 13 2018, 1:53 PM

Jun 12 2018

Lekensteyn added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

Since the code appears to be functionally correct, I am considering adding XFAIL for both cases.

Please do this for now to get the bot green again. If you figure out the root cause you can submit a fix later.

Jun 12 2018, 4:14 PM · Restricted Project
Lekensteyn committed rCRT334558: [ASAN] disable fgets_fputs test for android and darwin.
[ASAN] disable fgets_fputs test for android and darwin
Jun 12 2018, 4:09 PM
Lekensteyn committed rL334558: [ASAN] disable fgets_fputs test for android and darwin.
[ASAN] disable fgets_fputs test for android and darwin
Jun 12 2018, 4:09 PM
Lekensteyn added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

This is breaking the Android sanitizer bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/11563.

Please take a look and/or revert.

Jun 12 2018, 10:51 AM · Restricted Project
Lekensteyn committed rCRT334487: [ASAN] fix fgets and fgets_fputs tests failure.
[ASAN] fix fgets and fgets_fputs tests failure
Jun 12 2018, 2:31 AM
Lekensteyn committed rL334487: [ASAN] fix fgets and fgets_fputs tests failure.
[ASAN] fix fgets and fgets_fputs tests failure
Jun 12 2018, 2:31 AM

Jun 11 2018

Lekensteyn committed rL334450: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
[sanitizer] Add fgets, fputs and puts into sanitizer_common
Jun 11 2018, 4:02 PM
Lekensteyn committed rCRT334450: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
[sanitizer] Add fgets, fputs and puts into sanitizer_common
Jun 11 2018, 4:02 PM
Lekensteyn closed D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
Jun 11 2018, 4:02 PM · Restricted Project
Lekensteyn updated the diff for D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

Thanks Vitaly, that's a very useful tool!

Jun 11 2018, 3:59 PM · Restricted Project
Lekensteyn updated the diff for D48033: [ASAN] fix crash in GetGlobalsForAddress after dlclose.

Since performance was pretty bad at exit (see https://github.com/google/sanitizers/issues/963#issuecomment-396323984), I decided that optimization is mandatory for this version. UnregisterGlobals is apparently not only called for dlclose, but also for other shared libaries.

Jun 11 2018, 3:50 PM · Restricted Project
Lekensteyn added a comment to D48033: [ASAN] fix crash in GetGlobalsForAddress after dlclose.

Note: the issue was reproduced on both Linux (clang from trunk) and Windows (Clang 6.0.0). The fix was tested for Linux, but not on Windows (if someone has a setup ready, please test!). I also confirmed that the latest patch passes the test on Windows 7 and 10 (x64) and that without the patch, it crashes.

Jun 11 2018, 10:00 AM · Restricted Project
Lekensteyn created D48033: [ASAN] fix crash in GetGlobalsForAddress after dlclose.
Jun 11 2018, 9:49 AM · Restricted Project
Lekensteyn added inline comments to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
Jun 11 2018, 2:11 AM · Restricted Project

Jun 10 2018

Lekensteyn created D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
Jun 10 2018, 1:40 PM · Restricted Project
Lekensteyn closed D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.

Oops, I typoed "Differential Revision". Closing manually.

Jun 10 2018, 1:14 PM · Restricted Project
Lekensteyn added 1 commit(s) for D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later: rL334363: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Jun 10 2018, 1:12 PM · Restricted Project
Lekensteyn added an edge to rL334363: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later: D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Jun 10 2018, 1:12 PM
Lekensteyn updated the diff for D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

Changed since last patch: small fix to make the fputs test deterministically fail. No further test regressions caught during check-all.

--- a/test/asan/TestCases/Posix/fgets_fputs.cc
+++ b/test/asan/TestCases/Posix/fgets_fputs.cc
@@ -17,7 +17,7 @@ int test_fgets() {
Jun 10 2018, 10:54 AM · Restricted Project