This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix AMDGPUCodeGenPrepare using uninitialized AMDGPUAS struct
ClosedPublic

Authored by arsenm on Jun 27 2018, 5:31 AM.

Reviewers

rampitec
kzhuravl

Summary

Not sure how this wasn't noticed before.

LGTM

Not sure how this wasn't noticed before.

Possibly because only CONSTANT_ADDRESS and CONSTANT_ADDRESS_32BIT are accessed, and those are enum values

This revision is now accepted and ready to land.Jun 27 2018, 7:12 AM

LGTM

r335828

Path

Size

lib/

Target/

AMDGPU/

3 lines

	Show First 20 Lines • Show All 571 Lines • ▼ Show 20 Lines
	bool AMDGPUCodeGenPrepare::runOnFunction(Function &F) {			bool AMDGPUCodeGenPrepare::runOnFunction(Function &F) {
	if (skipFunction(F))			if (skipFunction(F))
	return false;			return false;

	auto *TPC = getAnalysisIfAvailable<TargetPassConfig>();			auto *TPC = getAnalysisIfAvailable<TargetPassConfig>();
	if (!TPC)			if (!TPC)
	return false;			return false;

	const TargetMachine &TM = TPC->getTM<TargetMachine>();			const AMDGPUTargetMachine &TM = TPC->getTM<AMDGPUTargetMachine>();
	ST = &TM.getSubtarget<SISubtarget>(F);			ST = &TM.getSubtarget<SISubtarget>(F);
	DA = &getAnalysis<DivergenceAnalysis>();			DA = &getAnalysis<DivergenceAnalysis>();
	HasUnsafeFPMath = hasUnsafeFPMath(F);			HasUnsafeFPMath = hasUnsafeFPMath(F);
				AMDGPUASI = TM.getAMDGPUAS();

	bool MadeChange = false;			bool MadeChange = false;

	for (BasicBlock &BB : F) {			for (BasicBlock &BB : F) {
	BasicBlock::iterator Next;			BasicBlock::iterator Next;
	for (BasicBlock::iterator I = BB.begin(), E = BB.end(); I != E; I = Next) {			for (BasicBlock::iterator I = BB.begin(), E = BB.end(); I != E; I = Next) {
	Next = std::next(I);			Next = std::next(I);
	MadeChange \|= visit(*I);			MadeChange \|= visit(*I);
	Show All 17 Lines