This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] fix for register coalescer
AbandonedPublic

Authored by dfukalov on Jun 25 2018, 12:31 PM.

Details

Reviewers
MatzeB
Summary

Added ability to return from joinSubRegRanges() in case of mapping was changed after check in joinVirtRegs()

Diff Detail

Repository
rL LLVM

Event Timeline

dfukalov created this revision.Jun 25 2018, 12:31 PM

The testcase compiles fine with ToT at r335473.

arsenm added a subscriber: arsenm.Jun 25 2018, 12:55 PM
arsenm added inline comments.
test/CodeGen/AMDGPU/regcoal-subrange-join-crash.ll
1–3

Subtle things like this really need a MIR testcase

dfukalov abandoned this revision.Jun 26 2018, 5:27 AM

The testcase compiles fine with ToT at r335473.

yep, your commit https://reviews.llvm.org/rL335472 fixed it, thanks!