This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] Add per-module indexes to combined index consistently
ClosedPublic

Authored by tejohnson on Jun 22 2018, 5:17 PM.

Details

Summary

Without this change we only add module paths to the combined index when
there is a module hash or at least one global value. Make this more
consistent by adding the module to the index whenever there is a summary
section, and it is a per-module summary (had a MODULE_CODE_SOURCE_FILENAME
record).

Since we will no longer add module paths lazily, add a new interface to get
the module info from the index that asserts it is already added.

Fixes PR37899.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Jun 22 2018, 5:17 PM
vlad.tsyrklevich accepted this revision.Jun 25 2018, 5:47 PM
vlad.tsyrklevich removed a reviewer: Vlad.
This revision is now accepted and ready to land.Jun 25 2018, 5:47 PM
pcc added inline comments.Jun 25 2018, 5:50 PM
lib/Bitcode/Reader/BitcodeReader.cpp
4812 ↗(On Diff #152559)

Can we make this function return void now?

tejohnson marked an inline comment as done.Jun 25 2018, 6:35 PM
tejohnson updated this revision to Diff 152817.Jun 25 2018, 6:36 PM

Address comment

This revision was automatically updated to reflect the committed changes.