This is an archive of the discontinued LLVM Phabricator instance.

[NFC][x86][AArch64] Add BEXTR-like test patterns.
ClosedPublic

Authored by lebedev.ri on Jun 22 2018, 10:03 AM.

Details

Summary

Also, adjust the check prefixes so that we actually get to check the BMI1-only-case.

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.Jun 22 2018, 10:03 AM

The X86 prefix changes LGTM if you want to commit that separately and leave this patch for just the arm guys to review

The X86 prefix changes LGTM if you want to commit that separately and leave this patch for just the arm guys to review

Thanks, i will commit the test/CodeGen/X86/extract-lowbits.ll part.

I'm honestly not sure about the test/CodeGen/*/extract-bits.ll,
we'd only need it if we want to actually let the BEXTR do the LSHR's work, too.
Or at least maybe the *_skipextrauses() tests aren't needed..

@lebedev.ri What happened with this patch? I can see x86/extract-lowbits.ll in trunk

@lebedev.ri What happened with this patch? I can see x86/extract-lowbits.ll in trunk

Nothing much. I committed the interesting subset of tests, but the rest is stuck just as the D48491.

RKSimon accepted this revision.Sep 19 2018, 5:22 AM

LGTM

This revision is now accepted and ready to land.Sep 19 2018, 5:22 AM

One last rebase

This revision was automatically updated to reflect the committed changes.
llvm/trunk/test/CodeGen/AArch64/extract-bits.ll