This is an archive of the discontinued LLVM Phabricator instance.

[DataFormatter] Add CFDictionary data formatter
ClosedPublic

Authored by JDevlieghere on Jun 21 2018, 11:29 AM.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jun 21 2018, 11:29 AM
JDevlieghere retitled this revision from Support CFDictionary to [DataFormatter] Add CFDictionary data formatter.
JDevlieghere edited the summary of this revision. (Show Details)
vsk accepted this revision.Jun 21 2018, 11:34 AM
vsk added a subscriber: vsk.

LGTM, thanks!

This revision is now accepted and ready to land.Jun 21 2018, 11:34 AM

It might be nice to split up the tests a bit. The data formatter tests have a history of testing 1000 things at once and saying "something failed in the this test with 1000 things". It would be nice if we knew that only dictionaries were failing by testing each type individually. Not required for this test, but try this out by reverting the changes in NSDictionary.cpp so you can see the kind of issue I am talking about.

  • Also test CFDictionaryRef

Yes, I really wish unittest2 allowed non-aborting tests. If you split up all these tests, then you make the testsuite have to build and run some little executable over and over. It would be so nice if there were a way to say:

self.startTestBundle()

self.assertTrue(something)
...
self.assertTrue(something_else)

self.endTestBundle()

where the failures would be held in the test bundle till "endTestBundle", and then all the failures reported.

That would allow us to test a bunch of independent things without having to build & run over and over.

Jim

This revision was automatically updated to reflect the committed changes.