This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Support -z initfirst
ClosedPublic

Authored by MaskRay on Jun 19 2018, 11:14 AM.

Download Raw Diff

Details

Reviewers

ruiu
echristo
• espindola

Commits

rGbd3684f25bfc: [ELF] Support -z initfirst
rLLD335090: [ELF] Support -z initfirst
rL335090: [ELF] Support -z initfirst

Summary

glibc uses this option to link libpthread.so

glibc/nptl/Makefile:
LDFLAGS-pthread.so = -Wl,--enable-new-dtags,-z,nodelete,-z,initfirst

Diff Detail

Repository: rL LLVM

Event Timeline

MaskRay created this revision.Jun 19 2018, 11:14 AM

Herald added a reviewer: • espindola. · View Herald TranscriptJun 19 2018, 11:14 AM

Herald added subscribers: llvm-commits, arichardson, emaste. · View Herald Transcript

Harbormaster completed remote builds in B19474: Diff 151951.Jun 19 2018, 11:15 AM

Seems reasonable and fairly obvious.

-eric

This revision is now accepted and ready to land.Jun 19 2018, 1:48 PM

Closed by commit rL335090: [ELF] Support -z initfirst (authored by MaskRay). · Explain WhyJun 19 2018, 7:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lld/

trunk/

ELF/

Config.h

1 line

Driver.cpp

1 line

SyntheticSections.cpp

2 lines

test/

ELF/

dt_flags.s

8 lines

Diff 152015

lld/trunk/ELF/Config.h

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines	struct Configuration {
bool WarnCommon;		bool WarnCommon;
bool WarnMissingEntry;		bool WarnMissingEntry;
bool WarnSymbolOrdering;		bool WarnSymbolOrdering;
bool WriteAddends;		bool WriteAddends;
bool ZCombreloc;		bool ZCombreloc;
bool ZCopyreloc;		bool ZCopyreloc;
bool ZExecstack;		bool ZExecstack;
bool ZHazardplt;		bool ZHazardplt;
		bool ZInitfirst;
bool ZKeepTextSectionPrefix;		bool ZKeepTextSectionPrefix;
bool ZNodelete;		bool ZNodelete;
bool ZNodlopen;		bool ZNodlopen;
bool ZNow;		bool ZNow;
bool ZOrigin;		bool ZOrigin;
bool ZRelro;		bool ZRelro;
bool ZRodynamic;		bool ZRodynamic;
bool ZText;		bool ZText;
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

lld/trunk/ELF/Driver.cpp

Show First 20 Lines • Show All 778 Lines • ▼ Show 20 Lines	Config->WarnBackrefs =
Args.hasFlag(OPT_warn_backrefs, OPT_no_warn_backrefs, false);		Args.hasFlag(OPT_warn_backrefs, OPT_no_warn_backrefs, false);
Config->WarnCommon = Args.hasFlag(OPT_warn_common, OPT_no_warn_common, false);		Config->WarnCommon = Args.hasFlag(OPT_warn_common, OPT_no_warn_common, false);
Config->WarnSymbolOrdering =		Config->WarnSymbolOrdering =
Args.hasFlag(OPT_warn_symbol_ordering, OPT_no_warn_symbol_ordering, true);		Args.hasFlag(OPT_warn_symbol_ordering, OPT_no_warn_symbol_ordering, true);
Config->ZCombreloc = getZFlag(Args, "combreloc", "nocombreloc", true);		Config->ZCombreloc = getZFlag(Args, "combreloc", "nocombreloc", true);
Config->ZCopyreloc = getZFlag(Args, "copyreloc", "nocopyreloc", true);		Config->ZCopyreloc = getZFlag(Args, "copyreloc", "nocopyreloc", true);
Config->ZExecstack = getZFlag(Args, "execstack", "noexecstack", false);		Config->ZExecstack = getZFlag(Args, "execstack", "noexecstack", false);
Config->ZHazardplt = hasZOption(Args, "hazardplt");		Config->ZHazardplt = hasZOption(Args, "hazardplt");
		Config->ZInitfirst = hasZOption(Args, "initfirst");
Config->ZKeepTextSectionPrefix = getZFlag(		Config->ZKeepTextSectionPrefix = getZFlag(
Args, "keep-text-section-prefix", "nokeep-text-section-prefix", false);		Args, "keep-text-section-prefix", "nokeep-text-section-prefix", false);
Config->ZNodelete = hasZOption(Args, "nodelete");		Config->ZNodelete = hasZOption(Args, "nodelete");
Config->ZNodlopen = hasZOption(Args, "nodlopen");		Config->ZNodlopen = hasZOption(Args, "nodlopen");
Config->ZNow = getZFlag(Args, "now", "lazy", false);		Config->ZNow = getZFlag(Args, "now", "lazy", false);
Config->ZOrigin = hasZOption(Args, "origin");		Config->ZOrigin = hasZOption(Args, "origin");
Config->ZRelro = getZFlag(Args, "relro", "norelro", true);		Config->ZRelro = getZFlag(Args, "relro", "norelro", true);
Config->ZRetpolineplt = hasZOption(Args, "retpolineplt");		Config->ZRetpolineplt = hasZOption(Args, "retpolineplt");
▲ Show 20 Lines • Show All 593 Lines • Show Last 20 Lines

lld/trunk/ELF/SyntheticSections.cpp

Show First 20 Lines • Show All 1,233 Lines • ▼ Show 20 Lines	template <class ELFT> void DynamicSection<ELFT>::finalizeContents() {
if (this->Size)		if (this->Size)
return; // Already finalized.		return; // Already finalized.

// Set DT_FLAGS and DT_FLAGS_1.		// Set DT_FLAGS and DT_FLAGS_1.
uint32_t DtFlags = 0;		uint32_t DtFlags = 0;
uint32_t DtFlags1 = 0;		uint32_t DtFlags1 = 0;
if (Config->Bsymbolic)		if (Config->Bsymbolic)
DtFlags \|= DF_SYMBOLIC;		DtFlags \|= DF_SYMBOLIC;
		if (Config->ZInitfirst)
		DtFlags1 \|= DF_1_INITFIRST;
if (Config->ZNodelete)		if (Config->ZNodelete)
DtFlags1 \|= DF_1_NODELETE;		DtFlags1 \|= DF_1_NODELETE;
if (Config->ZNodlopen)		if (Config->ZNodlopen)
DtFlags1 \|= DF_1_NOOPEN;		DtFlags1 \|= DF_1_NOOPEN;
if (Config->ZNow) {		if (Config->ZNow) {
DtFlags \|= DF_BIND_NOW;		DtFlags \|= DF_BIND_NOW;
DtFlags1 \|= DF_1_NOW;		DtFlags1 \|= DF_1_NOW;
}		}
▲ Show 20 Lines • Show All 1,720 Lines • Show Last 20 Lines

lld/trunk/test/ELF/dt_flags.s

	# REQUIRES: x86			# REQUIRES: x86

	# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t			# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
	# RUN: ld.lld -shared %t -o %t.so			# RUN: ld.lld -shared %t -o %t.so

	# RUN: ld.lld -z now -z nodelete -z nodlopen -z origin -Bsymbolic %t %t.so -o %t1			# RUN: ld.lld -z initfirst -z now -z nodelete -z nodlopen -z origin -Bsymbolic %t %t.so -o %t1
	# RUN: llvm-readobj -dynamic-table %t1 \| FileCheck -check-prefix=FLAGS %s			# RUN: llvm-readobj -dynamic-table %t1 \| FileCheck -check-prefix=FLAGS %s

	# RUN: ld.lld %t %t.so -o %t2			# RUN: ld.lld %t %t.so -o %t2
	# RUN: llvm-readobj -dynamic-table %t2 \| FileCheck %s			# RUN: llvm-readobj -dynamic-table %t2 \| FileCheck %s

	# RUN: ld.lld -z lazy %t %t.so -o %t2			# RUN: ld.lld -z lazy %t %t.so -o %t2
	# RUN: llvm-readobj -dynamic-table %t2 \| FileCheck %s			# RUN: llvm-readobj -dynamic-table %t2 \| FileCheck %s

	# FLAGS: DynamicSection [			# FLAGS: DynamicSection [
	# FLAGS: 0x000000000000001E FLAGS ORIGIN SYMBOLIC BIND_NOW			# FLAGS: 0x000000000000001E FLAGS ORIGIN SYMBOLIC BIND_NOW
	# FLAGS: 0x000000006FFFFFFB FLAGS_1 NOW NODELETE NOOPEN ORIGIN			# FLAGS: 0x000000006FFFFFFB FLAGS_1 NOW NODELETE INITFIRST NOOPEN ORIGIN
	# FLAGS: ]			# FLAGS: ]

	# CHECK: DynamicSection [			# CHECK: DynamicSection [
	# CHECK-NOT: 0x000000000000001E FLAGS ORIGIN SYMBOLIC BIND_NOW			# CHECK-NOT: FLAGS
	# CHECK-NOT: 0x000000006FFFFFFB FLAGS_1 NOW NODELETE NOOPEN ORIGIN			# CHECK-NOT: FLAGS_1
	# CHECK: ]			# CHECK: ]

	.globl _start			.globl _start
	_start:			_start: