This is an archive of the discontinued LLVM Phabricator instance.

Differential D48304

[WebAssembly] Fixed disassembler unit test failure.
ClosedPublic

Authored by aardappel on Jun 18 2018, 4:53 PM.

Details

Reviewers
dschuff
Commits
rGcf3a986087d0: [WebAssembly] Fixed disassembler unit test failure.
rL334999: [WebAssembly] Fixed disassembler unit test failure.
Summary

A recent commit forgot to update the unit tests.

Diff Detail

Event Timeline

aardappel created this revision.Jun 18 2018, 4:53 PM
Herald added subscribers: llvm-commits, sunfish, aheejin and 2 others. · View Herald TranscriptJun 18 2018, 4:53 PM
Harbormaster completed remote builds in B19446: Diff 151823.Jun 18 2018, 4:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 18 2018, 5:07 PM
Closed by commit rL334999: [WebAssembly] Fixed disassembler unit test failure. (authored by dschuff). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
unittests/
MC/
6 lines

Diff 151823

unittests/MC/Disassembler.cpp

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 LinesTEST(Disassembler, WebAssemblyTest) {
size_t InstSize; size_t InstSize;
unsigned NumBytes = sizeof(Bytes); unsigned NumBytes = sizeof(Bytes);
unsigned PC = 0; unsigned PC = 0;
InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString, InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString,
OutStringSize); OutStringSize);
EXPECT_EQ(InstSize, 1U); EXPECT_EQ(InstSize, 1U);
EXPECT_EQ(StringRef(OutString), "\ti32.add \t$0=, $0, $0"); EXPECT_EQ(StringRef(OutString), "\ti32.add ");
PC += InstSize; PC += InstSize;
BytesP += InstSize; BytesP += InstSize;
NumBytes -= InstSize; NumBytes -= InstSize;
InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString, InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString,
OutStringSize); OutStringSize);
EXPECT_EQ(InstSize, 2U); EXPECT_EQ(InstSize, 2U);
EXPECT_EQ(StringRef(OutString), "\ti64.const\t$0=, -1"); EXPECT_EQ(StringRef(OutString), "\ti64.const\t-1");
PC += InstSize; PC += InstSize;
BytesP += InstSize; BytesP += InstSize;
NumBytes -= InstSize; NumBytes -= InstSize;
InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString, InstSize = LLVMDisasmInstruction(DCR, BytesP, NumBytes, PC, OutString,
OutStringSize); OutStringSize);
EXPECT_EQ(InstSize, 3U); EXPECT_EQ(InstSize, 3U);
EXPECT_EQ(StringRef(OutString), "\ti64.load32_u\t$0=, 16($0):p2align=1"); EXPECT_EQ(StringRef(OutString), "\ti64.load32_u\t16, :p2align=1");
LLVMDisasmDispose(DCR); LLVMDisasmDispose(DCR);
} }