Page MenuHomePhabricator

[mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE
ClosedPublic

Authored by vstefanovic on Jun 14 2018, 6:28 AM.

Diff Detail

Repository
rC Clang

Event Timeline

vstefanovic created this revision.Jun 14 2018, 6:28 AM
atanasyan added inline comments.Jun 15 2018, 6:08 AM
include/clang/Driver/Options.td
2215

Does it make a sense to define this option as an alias to the mnocrc and allow to use both -mno-crc and -mnocrc for ARM and MIPS?

sdardis added inline comments.Jun 15 2018, 6:31 AM
include/clang/Driver/Options.td
2215

I thought about commenting on that. The problem there is that you then permitting clang to be more lax than binutils which inhibits compatibility between the two tools.

atanasyan accepted this revision.Jun 15 2018, 6:36 AM
atanasyan added inline comments.
include/clang/Driver/Options.td
2215

The problem there is that you then permitting clang to be more lax than binutils which inhibits compatibility between the two tools.

Good point. Agreed.

This revision is now accepted and ready to land.Jun 15 2018, 6:36 AM
This revision was automatically updated to reflect the committed changes.