Provide only one declaration of __throw_runtime_error

[dim]

Summary

In rL279903, @hiraditya added a second declaration of
__throw_runtime_error to include/__locale. The original declaration
was in __locale too, but @mclow.lists moved it from there to
stdexcept.

In FreeBSD we compile most things with gcc's -Wredundant-decls, which
warns about such redundant redeclations, so I would like to remove the
one in stdexcept, as all the other callers of the function already
include __locale anyway.

While here, move the declaration in __locale to just above its first
invocation.

[mclow.lists]

I'm not really happy with gcc's redundant declaration warnings; I think they're "nannying" rather than useful.

That being said, why not just remove the declaration in __locale?
__locale includes string, which includes stdexcept.

[hiraditya]

Any updates on this one? I like @mclow.lists idea of removing it from __locale.

[dim]

Obsoleted by D58425 (and rCXX354515).

include/__locale

private:
     id(const id&); // = delete;
 public:  // only needed for tests
     long __get();
 
     friend class locale;
     friend class locale::__imp;
 };
 
+_LIBCPP_NORETURN _LIBCPP_FUNC_VIS void __throw_runtime_error(const char*);
+
 template <class _Facet>
 inline _LIBCPP_INLINE_VISIBILITY
 locale::locale(const locale& __other, _Facet* __f)
 {
     __install_ctor(__other, __f, __f ? __f->id.__get() : 0);
 }
 
 template <class _Facet>

 {
 }
 
 _LIBCPP_EXTERN_TEMPLATE2(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS codecvt_byname<char, char, mbstate_t>)
 _LIBCPP_EXTERN_TEMPLATE2(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS codecvt_byname<wchar_t, char, mbstate_t>)
 _LIBCPP_EXTERN_TEMPLATE2(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS codecvt_byname<char16_t, char, mbstate_t>)
 _LIBCPP_EXTERN_TEMPLATE2(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS codecvt_byname<char32_t, char, mbstate_t>)
 
-_LIBCPP_NORETURN _LIBCPP_FUNC_VIS void __throw_runtime_error(const char*);
-
 template <size_t _Np>
 struct __narrow_to_utf8
 {
     template <class _OutputIterator, class _CharT>
     _OutputIterator
     operator()(_OutputIterator __s, const _CharT* __wb, const _CharT* __we) const;
 };
 

include/stdexcept

public:
 
     virtual ~underflow_error() _NOEXCEPT;
 };
 
 }  // std
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
-// in the dylib
-_LIBCPP_NORETURN _LIBCPP_FUNC_VIS void __throw_runtime_error(const char*);
-
 _LIBCPP_NORETURN inline _LIBCPP_ALWAYS_INLINE
 void __throw_logic_error(const char*__msg)
 {
 #ifndef _LIBCPP_NO_EXCEPTIONS
     throw logic_error(__msg);
 #else
     ((void)__msg);
     _VSTD::abort();