Page MenuHomePhabricator

[mips] Add additional parameter to LONG_BRANCH_LUi/ADDiu pseudo instructions
ClosedPublic

Authored by abeserminji on Jun 8 2018, 6:12 AM.

Details

Summary

Extend LONG_BRANCH_LUi and LONG_BRANCH_ADDiu pseudo instructions
with additional flag, so instead of always lowering to lui %hi(...), addiu %lo(...) or addiu %hi(...),
now they can lower to either %lo, %hi, %higher or %highest depending on the added flag.

Diff Detail

Repository
rL LLVM

Event Timeline

abeserminji created this revision.Jun 8 2018, 6:12 AM
abeserminji edited the summary of this revision. (Show Details)Jun 8 2018, 6:14 AM
sdardis accepted this revision.Jun 11 2018, 4:22 AM

LGTM with nit addressed.

lib/Target/Mips/MipsMCInstLower.cpp
274

Spurious semi-colon.

This revision is now accepted and ready to land.Jun 11 2018, 4:22 AM
abeserminji marked an inline comment as done.

Comment addressed.

This revision was automatically updated to reflect the committed changes.