Page MenuHomePhabricator

AMDGPU: Error on LDS global address in functions
ClosedPublic

Authored by arsenm on Jun 7 2018, 12:18 PM.

Details

Summary

These won't work as expected now, so error on them to avoid
wasting time debugging this in the future.

Not sure what the best terminology to use in the error message is

Diff Detail

Event Timeline

arsenm created this revision.Jun 7 2018, 12:18 PM
This revision is now accepted and ready to land.Jun 7 2018, 12:20 PM
t-tye added inline comments.Jun 7 2018, 12:45 PM
lib/Target/AMDGPU/AMDGPUISelLowering.cpp
1279

Should this also give an error for any non-global address space? I think the same issue exists if global private or region address space happens. In that case therror message would be "global variables in non global address space not supported in non-kernel functions".

arsenm added inline comments.Jun 8 2018, 1:06 AM
lib/Target/AMDGPU/AMDGPUISelLowering.cpp
1279

This works fine for constant

t-tye added inline comments.Jun 8 2018, 1:09 AM
lib/Target/AMDGPU/AMDGPUISelLowering.cpp
1279

But probably not for private (scratch) or region (GDS).

arsenm closed this revision.Jun 8 2018, 1:10 AM

r334269