This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Pass additional CMake tools to external projects
ClosedPublic

Authored by phosek on Jun 6 2018, 10:12 AM.

Details

Summary

This is needed when the external projects try to use other tools
besides just the compiler and the linker.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jun 6 2018, 10:12 AM
This revision is now accepted and ready to land.Jun 6 2018, 12:40 PM
smeenai accepted this revision.Jun 6 2018, 2:01 PM

LGTM

llvm/cmake/modules/LLVMExternalProjectUtils.cmake
111

Do we only care about ELF?

phosek added inline comments.Jun 6 2018, 2:28 PM
llvm/cmake/modules/LLVMExternalProjectUtils.cmake
111

Ideally this would support other platforms as well, but there are other bits in this function that would need to be probably changed as well, e.g. CMAKE_C_COMPILER and CMAKE_CXX_COMPILER should be also pointing to clang-cl when target system is Windows, so I'm not sure if it's worth doing all that in this patch?

smeenai added inline comments.Jun 6 2018, 2:31 PM
llvm/cmake/modules/LLVMExternalProjectUtils.cmake
111

Yeah, that's fair. This is fine as-is; I was just wondering in general.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 7:20 AM