This is an archive of the discontinued LLVM Phabricator instance.

[MSan] Report proper error on allocator failures instead of CHECK(0)-ing
ClosedPublic

Authored by alekseyshl on Jun 5 2018, 11:30 AM.

Details

Summary

Following up on and complementing D44404.

Currently many allocator specific errors (OOM, for example) are reported as
a text message and CHECK(0) termination, not stack, no details, not too
helpful nor informative. To improve the situation, detailed and
structured errors were defined and reported under the appropriate conditions.

Event Timeline

alekseyshl created this revision.Jun 5 2018, 11:30 AM
Herald added subscribers: Restricted Project, delcypher, srhines. · View Herald TranscriptJun 5 2018, 11:30 AM
  • Add stack trace check to pvalloc test
vitalybuka added inline comments.Jun 7 2018, 2:20 PM
test/msan/Posix/lit.local.cfg
9

we don't have msan on windows?
I guess it's always posix

alekseyshl added inline comments.Jun 7 2018, 3:16 PM
test/msan/Posix/lit.local.cfg
9

No, we do not. But I'd rather have the same config in all sanitizers, easier to maintain, don't you agree?

vitalybuka added inline comments.Jun 7 2018, 4:50 PM
test/msan/Posix/lit.local.cfg
9

They are very different and independent so I am not sure how exactly this simplify maintains.
However now for each tests we will have need to decide if this is Posix test or common test, when in fact there is not difference.
Lets keep it without Posix dir until we rely need it.

alekseyshl updated this revision to Diff 150434.Jun 7 2018, 5:17 PM
  • Add stack trace check to pvalloc test
  • Do not create Posix specific tests just yet
alekseyshl marked an inline comment as done.Jun 7 2018, 5:18 PM

Done

vitalybuka accepted this revision.Jun 7 2018, 5:28 PM
This revision is now accepted and ready to land.Jun 7 2018, 5:28 PM
alekseyshl updated this revision to Diff 150581.Jun 8 2018, 3:49 PM
  • rebasing
This revision was automatically updated to reflect the committed changes.