This is an archive of the discontinued LLVM Phabricator instance.

Differential D47657

ELF: Ignore argument after --plugin.
ClosedPublic

Authored by pcc on Jun 1 2018, 2:43 PM.

Details

Reviewers
ruiu
• espindola
Commits
rG7234acf5bb20: ELF: Ignore argument after --plugin.
rL333793: ELF: Ignore argument after --plugin.
rLLD333793: ELF: Ignore argument after --plugin.
Summary

Clang passes --plugin /path/to/LLVMgold.so to the linker when -flto is
passed. After r333607 we only ignore --plugin as a joined argument,
which means that the following argument (/path/to/LLVMgold.so) is
interpreted as an input file. This means that either every LTO'd
program ends up being linked with the gold plugin or we error out
if the plugin does not exist. The fix is to use Eq to ignore both
--plugin=foo and --plugin foo as before.

Diff Detail

Event Timeline

pcc created this revision.Jun 1 2018, 2:43 PM
Harbormaster completed remote builds in B18851: Diff 149557.Jun 1 2018, 2:43 PM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 1 2018, 2:43 PM
Herald added a reviewer: • espindola. · View Herald Transcript
Herald added subscribers: arichardson, mehdi_amini, emaste. · View Herald Transcript
ruiu added a comment.Jun 1 2018, 2:45 PM

Could you add a test?

pcc updated this revision to Diff 149559.Jun 1 2018, 2:49 PM
  • Add test
ruiu accepted this revision.Jun 1 2018, 2:50 PM

LGTM

This revision is now accepted and ready to land.Jun 1 2018, 2:50 PM
Closed by commit rLLD333793: ELF: Ignore argument after --plugin. (authored by pcc). · Explain WhyJun 1 2018, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
ELF/
2 lines
test/
ELF/
2 lines

Diff 149559

lld/ELF/Options.td

Show First 20 Lines • Show All 437 Lines • ▼ Show 20 Lines
// Ignore LTO plugin-related options. // Ignore LTO plugin-related options.
// clang -flto passes -plugin and -plugin-opt to the linker. This is required // clang -flto passes -plugin and -plugin-opt to the linker. This is required
// for ld.gold and ld.bfd to get LTO working. But it's not for lld which doesn't // for ld.gold and ld.bfd to get LTO working. But it's not for lld which doesn't
// rely on a plugin. Instead of detecting which linker is used on clang side we // rely on a plugin. Instead of detecting which linker is used on clang side we
// just ignore the option on lld side as it's easier. In fact, the linker could // just ignore the option on lld side as it's easier. In fact, the linker could
// be called 'ld' and understanding which linker is used would require parsing of // be called 'ld' and understanding which linker is used would require parsing of
// --version output. // --version output.
def plugin: J<"plugin">; defm plugin: Eq<"plugin", "Ignored for compatibility with GNU linkers">;
def plugin_opt_fresolution_eq: J<"plugin-opt=-fresolution=">; def plugin_opt_fresolution_eq: J<"plugin-opt=-fresolution=">;
def plugin_opt_pass_through_eq: J<"plugin-opt=-pass-through=">; def plugin_opt_pass_through_eq: J<"plugin-opt=-pass-through=">;
def plugin_opt_thinlto: J<"plugin-opt=thinlto">; def plugin_opt_thinlto: J<"plugin-opt=thinlto">;
def plugin_opt_slash: J<"plugin-opt=/">; def plugin_opt_slash: J<"plugin-opt=/">;
// Options listed below are silently ignored for now for compatibility. // Options listed below are silently ignored for now for compatibility.
def: F<"allow-shlib-undefined">; def: F<"allow-shlib-undefined">;
Show All 21 Lines

lld/test/ELF/ignore-plugin.test

  • This file was added.
RUN: not ld.lld --plugin foo 2>&1 | FileCheck %s
CHECK: no input files