This is an archive of the discontinued LLVM Phabricator instance.

[LSan] Report proper error on allocator failures instead of CHECK(0)-ing
ClosedPublic

Authored by alekseyshl on Jun 1 2018, 11:18 AM.

Details

Summary

Following up on and complementing D44404.

Currently many allocator specific errors (OOM, for example) are reported as
a text message and CHECK(0) termination, not stack, no details, not too
helpful nor informative. To improve the situation, detailed and
structured errors were defined and reported under the appropriate conditions.

Diff Detail

Event Timeline

alekseyshl created this revision.Jun 1 2018, 11:18 AM
Herald added subscribers: Restricted Project, delcypher, mgorny, srhines. · View Herald TranscriptJun 1 2018, 11:18 AM
alekseyshl updated this revision to Diff 149880.Jun 4 2018, 6:04 PM
  • Move allocator errors reporting to common to share with other sanitizers.
eugenis accepted this revision.Jun 5 2018, 10:55 AM

Looks great.

This revision is now accepted and ready to land.Jun 5 2018, 10:55 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.