Page MenuHomePhabricator

Add dependency on clang-headers when building LLDB.framework using CMake
ClosedPublic

Authored by xiaobai on May 31 2018, 4:29 PM.

Details

Summary

The LLDB.framework generated when building with CMake + Ninja/Make is
completely missing the clang headers. Although the code to copy them exists, we
don't even generate them unless we're building LLDB standalone.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.May 31 2018, 4:29 PM
labath accepted this revision.Jun 1 2018, 1:45 AM

I don't understand the interactions between lldb framework and clang headers, but if there isn't a better person to review this, I'm happy to rubber-stamp it. :)

This revision is now accepted and ready to land.Jun 1 2018, 1:45 AM
clayborg accepted this revision.Jun 1 2018, 9:30 AM
This revision was automatically updated to reflect the committed changes.
xiaobai added a comment.EditedJun 1 2018, 11:20 AM

I don't understand the interactions between lldb framework and clang headers, but if there isn't a better person to review this, I'm happy to rubber-stamp it. :)

Thanks! I don't quite understand it either, but I am trying to make it so we can build the LLDB framework with just CMake+Make/Ninja. :)