This is an archive of the discontinued LLVM Phabricator instance.

Add "(default)" to default options
ClosedPublic

Authored by ruiu on May 30 2018, 3:37 PM.

Event Timeline

ruiu created this revision.May 30 2018, 3:37 PM
pcc accepted this revision.May 30 2018, 4:02 PM

LGTM

This revision is now accepted and ready to land.May 30 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Hi @ruiu,

I was just looking at this change, and I noticed one slight mistake in this: the --discard-none switch is not the default behaviour of LLD. If it were, the default DiscardPolicy would be DiscardPolicy::None, when in fact it is DiscardPolicy::Default and there's a difference in the behaviour between the two in shouldKeepInSymtab.

ruiu added a comment.May 31 2018, 6:03 AM

Oh, thank you for finding that mistake! I'll just remove "(default)" from that option.