When running the ASTTests test, warnings produced by the compiler can be
distracting when looking for test errors. A part of the warnings is removed
by setting extra compiler options.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Hello Balázs!
Thank you for addressing this problem, it is really cool. However, it will be much better if we don't suppress warnings but fix them. Could you modify the tests instead?
Original idea was to not modify the test code to keep it as simple as possible. If you like it better I will change the test code.
[ASTImporter] Fixed test code in ASTImporter tests.
Test code is fixed instead of turn off the warnings.
For this to work change of match expressions was needed.
Hello Balázs,
The patch is mostly LG now, thank you!
unittests/AST/ASTImporterTest.cpp | ||
---|---|---|
495 ↗ | (On Diff #149079) | Redundant space after cast. |
541 ↗ | (On Diff #149079) | Commented code should be removed. |
802 ↗ | (On Diff #149079) | Sometimes we turn to usehasDescendant(), sometimes we add a cast matcher. Can we make it consistent? |
[ASTImporter] Fixed test code in ASTImporter tests.
Reformatted some test code, changed to use isDescendant.
Some of the source code was reformatted for more consistency. At least a part of the code is now better formatted.
Thank you!
When committing, please change the commit message (the current review description is out-of-date) and mention the reformatting done.