This is an archive of the discontinued LLVM Phabricator instance.

Differential D47398

[WebAssembly] MC: Add compile-twice test and fix corresponding bug
ClosedPublic

Authored by sbc100 on May 25 2018, 4:35 PM.

Details

Reviewers
sunfish
dschuff
Commits
rG105bdc255732: [WebAssembly] MC: Add compile-twice test and fix corresponding bug
rL333494: [WebAssembly] MC: Add compile-twice test and fix corresponding bug

Diff Detail

Event Timeline

sbc100 created this revision.May 25 2018, 4:35 PM
Herald added subscribers: llvm-commits, sunfish, aheejin and 2 others. · View Herald TranscriptMay 25 2018, 4:35 PM
Harbormaster completed remote builds in B18609: Diff 148686.May 25 2018, 4:35 PM
sbc100 added reviewers: sunfish, dschuff.May 25 2018, 4:37 PM
sbc100 updated this revision to Diff 148687.May 25 2018, 4:38 PM
  • update comment
Harbormaster completed remote builds in B18610: Diff 148687.May 25 2018, 4:38 PM
dschuff accepted this revision.May 29 2018, 4:16 PM
This revision is now accepted and ready to land.May 29 2018, 4:16 PM
Closed by commit rL333494: [WebAssembly] MC: Add compile-twice test and fix corresponding bug (authored by sbc). · Explain WhyMay 29 2018, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
MC/
1 line
2 lines
test/
MC/
WebAssembly/
14 lines

Diff 148686

lib/MC/MCContext.cpp

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Linesvoid MCContext::reset() {
DwarfCompileUnitID = 0; DwarfCompileUnitID = 0;
CurrentDwarfLoc = MCDwarfLoc(0, 0, 0, DWARF2_FLAG_IS_STMT, 0, 0); CurrentDwarfLoc = MCDwarfLoc(0, 0, 0, DWARF2_FLAG_IS_STMT, 0, 0);
CVContext.reset(); CVContext.reset();
MachOUniquingMap.clear(); MachOUniquingMap.clear();
ELFUniquingMap.clear(); ELFUniquingMap.clear();
COFFUniquingMap.clear(); COFFUniquingMap.clear();
WasmUniquingMap.clear();
NextID.clear(); NextID.clear();
AllowTemporaryLabels = true; AllowTemporaryLabels = true;
DwarfLocSeen = false; DwarfLocSeen = false;
GenDwarfForAssembly = false; GenDwarfForAssembly = false;
GenDwarfFileNumber = 0; GenDwarfFileNumber = 0;
HadError = false; HadError = false;
▲ Show 20 Lines • Show All 494 Lines • Show Last 20 Lines

lib/MC/WasmObjectWriter.cpp

Show First 20 Lines • Show All 264 Lines • ▼ Show 20 Lines void reset() override {
TableIndices.clear(); TableIndices.clear();
DataLocations.clear(); DataLocations.clear();
CustomSectionsRelocations.clear(); CustomSectionsRelocations.clear();
FunctionTypeIndices.clear(); FunctionTypeIndices.clear();
FunctionTypes.clear(); FunctionTypes.clear();
Globals.clear(); Globals.clear();
DataSegments.clear(); DataSegments.clear();
SectionFunctions.clear(); SectionFunctions.clear();
MCObjectWriter::reset();
NumFunctionImports = 0; NumFunctionImports = 0;
NumGlobalImports = 0; NumGlobalImports = 0;
MCObjectWriter::reset();
} }
void writeHeader(const MCAssembler &Asm); void writeHeader(const MCAssembler &Asm);
void recordRelocation(MCAssembler &Asm, const MCAsmLayout &Layout, void recordRelocation(MCAssembler &Asm, const MCAsmLayout &Layout,
const MCFragment *Fragment, const MCFixup &Fixup, const MCFragment *Fragment, const MCFixup &Fixup,
MCValue Target, uint64_t &FixedValue) override; MCValue Target, uint64_t &FixedValue) override;
▲ Show 20 Lines • Show All 1,200 Lines • Show Last 20 Lines

test/MC/WebAssembly/compile-twice.ll

  • This file was added.
; Check that there is no persistent state in the MachO emitter that crashes
; us when reusing the pass manager.
; RUN: llc -mtriple=wasm32-unknown-unknown -compile-twice -filetype=obj %s -o -
; Force the creation of a DWARF section
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!3, !4}
@myglobal = global i32 0, align 4
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "LLVM", isOptimized: true, emissionKind: FullDebug)
!1 = !DIFile(filename: "<stdin>", directory: "/")
!3 = !{i32 2, !"Dwarf Version", i32 4}
!4 = !{i32 2, !"Debug Info Version", i32 3}