Page MenuHomePhabricator

[clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C πŸ“œ
ClosedPublic

Authored by stephanemoore on May 25 2018, 2:27 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

stephanemoore created this revision.May 25 2018, 2:27 PM

Removed the last format from the tests. That particular scenario was failing and it might need additional changes to pass. I also think that particular scenario is not critical to the change and can be considered in a followup.

Polling the Google Objective-C community to see if anyone objects to this change. So far no concerns have been raised.

I believe I have consensus that this is the correct change for Google Objective-C style.

benhamilton accepted this revision.Jun 7 2018, 11:34 AM
This revision is now accepted and ready to land.Jun 7 2018, 11:34 AM

Are additional approvals needed to land this? I pinged jolesiak earlier this week asking if he had any comments but have not heard back yet.

(also, once necessary approvals have been granted can I request help from someone to land it for me? πŸ˜‡)

I'll just land it for you.

This revision was automatically updated to reflect the committed changes.

Sorry, I missed that.
LGTM, I would consider adding ObjC method expression tests (multiline string as an argument). Will look into that next week.