This is an archive of the discontinued LLVM Phabricator instance.

[modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual
ClosedPublic

Authored by teemperor on May 23 2018, 12:50 PM.

Details

Summary

Since clang r332929 these two headers throw errors when included from somewhere else than their wrapper header. It seems marking them as textual is the best way to fix the builds.

Fixes this new module build error:

While building module '_Builtin_intrinsics' imported from ...:
In file included from <module-includes>:2:
In file included from lib/clang/7.0.0/include/immintrin.h:54:
In file included from lib/clang/7.0.0/include/wmmintrin.h:29:
lib/clang/7.0.0/include/__wmmintrin_aes.h:25:2: error: "Never use <__wmmintrin_aes.h> directly; include <wmmintrin.h> instead."
#error "Never use <__wmmintrin_aes.h> directly; include <wmmintrin.h> instead."

Diff Detail

Event Timeline

teemperor created this revision.May 23 2018, 12:50 PM
teemperor edited reviewers, added: v.g.vassilev; removed: slydiman.

(Wrong Vassil, sorry)

craig.topper accepted this revision.May 23 2018, 1:30 PM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.May 23 2018, 1:30 PM
This revision was automatically updated to reflect the committed changes.