Page MenuHomePhabricator

slydiman (Dmitry Vassiliev)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2014, 3:55 AM (416 w, 2 d)

Recent Activity

Mon, Nov 14

slydiman committed rGc6a199fb4fc0: [NVPTX] Emit pragma nounroll for llvm.loop.unroll.count=1 (authored by slydiman).
[NVPTX] Emit pragma nounroll for llvm.loop.unroll.count=1
Mon, Nov 14, 4:31 PM · Restricted Project, Restricted Project
slydiman closed D137991: [NVPTX] Emit pragma nounroll for llvm.loop.unroll.count=1.
Mon, Nov 14, 4:30 PM · Restricted Project, Restricted Project
slydiman updated the diff for D137991: [NVPTX] Emit pragma nounroll for llvm.loop.unroll.count=1.
Mon, Nov 14, 3:38 PM · Restricted Project, Restricted Project
slydiman requested review of D137991: [NVPTX] Emit pragma nounroll for llvm.loop.unroll.count=1.
Mon, Nov 14, 3:13 PM · Restricted Project, Restricted Project

Oct 2 2022

slydiman abandoned D133235: [DAGCombiner] More opportunities to fuse fmul and fadd to fma aggressively.

It seems already implemented here https://reviews.llvm.org/D132837

Oct 2 2022, 3:42 PM · Restricted Project, Restricted Project

Sep 15 2022

slydiman added a comment to D133235: [DAGCombiner] More opportunities to fuse fmul and fadd to fma aggressively.

Ping

Sep 15 2022, 12:05 PM · Restricted Project, Restricted Project

Sep 5 2022

slydiman updated the diff for D133235: [DAGCombiner] More opportunities to fuse fmul and fadd to fma aggressively.
Sep 5 2022, 9:55 PM · Restricted Project, Restricted Project

Sep 2 2022

slydiman requested review of D133235: [DAGCombiner] More opportunities to fuse fmul and fadd to fma aggressively.
Sep 2 2022, 2:27 PM · Restricted Project, Restricted Project

Aug 24 2022

slydiman committed rG9174a5e9a845: [NVPTX] SHL.64 $r, 31 cannot be converted to a mulwide.s32 (authored by slydiman).
[NVPTX] SHL.64 $r, 31 cannot be converted to a mulwide.s32
Aug 24 2022, 2:40 AM · Restricted Project, Restricted Project
slydiman closed D132516: [NVPTX] SHL.64 $r, 31 cannot be converted to a mulwide.s32.
Aug 24 2022, 2:40 AM · Restricted Project, Restricted Project

Aug 23 2022

slydiman updated the diff for D132516: [NVPTX] SHL.64 $r, 31 cannot be converted to a mulwide.s32.
Aug 23 2022, 5:15 PM · Restricted Project, Restricted Project
slydiman requested review of D132516: [NVPTX] SHL.64 $r, 31 cannot be converted to a mulwide.s32.
Aug 23 2022, 4:30 PM · Restricted Project, Restricted Project

Aug 15 2022

slydiman committed rG5371ab445618: [IR] Change access rights of PredIterator members (authored by slydiman).
[IR] Change access rights of PredIterator members
Aug 15 2022, 5:26 AM · Restricted Project, Restricted Project
slydiman closed D131608: [IR] Change access rights of PredIterator members .
Aug 15 2022, 5:26 AM · Restricted Project, Restricted Project

Aug 10 2022

slydiman requested review of D131608: [IR] Change access rights of PredIterator members .
Aug 10 2022, 11:38 AM · Restricted Project, Restricted Project

Jul 30 2022

slydiman committed rGadc387460d85: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and… (authored by slydiman).
[CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and…
Jul 30 2022, 9:25 AM · Restricted Project, Restricted Project
slydiman closed D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS.
Jul 30 2022, 9:25 AM · Restricted Project, Restricted Project

Jul 28 2022

slydiman added reviewers for D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS: RKSimon, MaskRay.
Jul 28 2022, 10:45 AM · Restricted Project, Restricted Project

Jul 26 2022

slydiman committed rGe3e63f30a5da: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and… (authored by slydiman).
[CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and…
Jul 26 2022, 3:22 PM · Restricted Project, Restricted Project
slydiman closed D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 26 2022, 3:22 PM · Restricted Project, Restricted Project

Jul 25 2022

slydiman added inline comments to D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 25 2022, 4:37 PM · Restricted Project, Restricted Project
slydiman added inline comments to D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 25 2022, 3:12 PM · Restricted Project, Restricted Project

Jul 23 2022

slydiman updated the summary of D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 12:14 PM · Restricted Project, Restricted Project
slydiman added inline comments to D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 12:09 PM · Restricted Project, Restricted Project
slydiman updated the summary of D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 12:09 PM · Restricted Project, Restricted Project
slydiman updated the summary of D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 12:06 PM · Restricted Project, Restricted Project
slydiman added inline comments to D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 11:53 AM · Restricted Project, Restricted Project
slydiman updated the diff for D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 11:49 AM · Restricted Project, Restricted Project
slydiman retitled D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS from [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG to [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS.
Jul 23 2022, 11:18 AM · Restricted Project, Restricted Project
slydiman added a reviewer for D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP: aaron.ballman.
Jul 23 2022, 11:09 AM · Restricted Project, Restricted Project
slydiman updated the diff for D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 11:09 AM · Restricted Project, Restricted Project
slydiman retitled D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP from [CodeGen] Fixed ambiguous symbol `ExtAddrMode` in case of NDEBUG to [CodeGen] Fixed ambiguous symbol `ExtAddrMode` in case of LLVM_ENABLE_DUMP.
Jul 23 2022, 11:02 AM · Restricted Project, Restricted Project
slydiman added inline comments to D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 10:51 AM · Restricted Project, Restricted Project
slydiman retitled D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS from [CodeGen] Fixed undeclared MISchedCutoff to [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG.
Jul 23 2022, 9:33 AM · Restricted Project, Restricted Project
slydiman requested review of D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP.
Jul 23 2022, 9:33 AM · Restricted Project, Restricted Project
slydiman updated the diff for D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS.
Jul 23 2022, 9:21 AM · Restricted Project, Restricted Project
slydiman requested review of D130425: [CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS.
Jul 23 2022, 8:58 AM · Restricted Project, Restricted Project
slydiman committed rG4acc02357e58: [IR] Fixed ambiguous call to llvm::report_fatal_error (authored by slydiman).
[IR] Fixed ambiguous call to llvm::report_fatal_error
Jul 23 2022, 7:28 AM · Restricted Project, Restricted Project
slydiman closed D130407: [IR] Fixed ambiguous call to llvm::report_fatal_error.
Jul 23 2022, 7:28 AM · Restricted Project, Restricted Project

Jul 22 2022

slydiman updated the diff for D130407: [IR] Fixed ambiguous call to llvm::report_fatal_error.
Jul 22 2022, 9:12 PM · Restricted Project, Restricted Project
slydiman updated the diff for D130407: [IR] Fixed ambiguous call to llvm::report_fatal_error.
Jul 22 2022, 9:08 PM · Restricted Project, Restricted Project
slydiman added a reviewer for D130407: [IR] Fixed ambiguous call to llvm::report_fatal_error: RKSimon.
Jul 22 2022, 6:29 PM · Restricted Project, Restricted Project
slydiman requested review of D130407: [IR] Fixed ambiguous call to llvm::report_fatal_error.
Jul 22 2022, 6:26 PM · Restricted Project, Restricted Project

Jun 9 2022

slydiman abandoned D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit.
Jun 9 2022, 11:53 AM · debug-info, Restricted Project, Restricted Project

May 18 2022

slydiman added a comment to D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit.

Ping

May 18 2022, 2:40 AM · debug-info, Restricted Project, Restricted Project

May 17 2022

slydiman committed rG9983b978f756: [SROA] Precommit test for D124967 (authored by slydiman).
[SROA] Precommit test for D124967
May 17 2022, 2:26 AM · Restricted Project, Restricted Project
slydiman committed rG7759680e2f88: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in… (authored by slydiman).
[SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in…
May 17 2022, 2:26 AM · Restricted Project, Restricted Project
slydiman closed D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 17 2022, 2:26 AM · Restricted Project, Restricted Project

May 16 2022

slydiman updated the diff for D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 16 2022, 2:13 PM · Restricted Project, Restricted Project
slydiman added inline comments to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 16 2022, 1:08 PM · Restricted Project, Restricted Project
slydiman added inline comments to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 16 2022, 12:45 PM · Restricted Project, Restricted Project
slydiman updated the diff for D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 16 2022, 12:41 PM · Restricted Project, Restricted Project

May 15 2022

slydiman updated the diff for D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit.

I have simplified the test and made it generic.

May 15 2022, 4:23 PM · debug-info, Restricted Project, Restricted Project

May 13 2022

slydiman added a comment to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.

Why do you think the results of SROA should be the same with an without lifetime intrinsics?

May 13 2022, 12:03 PM · Restricted Project, Restricted Project
slydiman added a comment to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.

Ping

May 13 2022, 8:31 AM · Restricted Project, Restricted Project

May 12 2022

slydiman committed rG7b22cf12ef9f: [Intrinsics] Fix `nvvm_prmt` intrinsic attributes (authored by slydiman).
[Intrinsics] Fix `nvvm_prmt` intrinsic attributes
May 12 2022, 1:47 AM · Restricted Project, Restricted Project
slydiman closed D125423: [Intrinsics] Fix `nvvm_prmt` intrinsic attributes.
May 12 2022, 1:46 AM · Restricted Project, Restricted Project

May 11 2022

slydiman requested review of D125423: [Intrinsics] Fix `nvvm_prmt` intrinsic attributes.
May 11 2022, 2:30 PM · Restricted Project, Restricted Project

May 6 2022

slydiman updated the diff for D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 6 2022, 9:54 AM · Restricted Project, Restricted Project
slydiman added a comment to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.

I have updated the code and removed the loop from the test.

May 6 2022, 9:09 AM · Restricted Project, Restricted Project
slydiman updated the diff for D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 6 2022, 8:51 AM · Restricted Project, Restricted Project
slydiman added a comment to D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.

If I take your example with and without lifetime intrinsics, then with current SROA, the variant without intrinsics produces a worse result: https://llvm.godbolt.org/z/oPMKWzaMq
Results of SROA should be the same with an without lifetime intrinsics, but I'm not sure your patch achieves that -- it looks like it produces a third variant that is better than both?

Here is the result after this patch. Compare the while_body section.

define i16 @foo(i32* nocapture readonly %loop) #1 {
entry:
  br label %while_cond
May 6 2022, 7:22 AM · Restricted Project, Restricted Project

May 5 2022

slydiman added a reviewer for D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit: tra.
May 5 2022, 6:57 PM · debug-info, Restricted Project, Restricted Project
slydiman updated the diff for D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.

I have updated the test. Now it is generic, not NVPTX specific.

May 5 2022, 6:40 PM · Restricted Project, Restricted Project

May 4 2022

slydiman requested review of D124967: [SROA] Avoid postponing rewriting load/store by ignoring lifetime intrinsics in partition's promotability checking.
May 4 2022, 2:50 PM · Restricted Project, Restricted Project

May 3 2022

slydiman added a comment to D119669: [NVPTX] Prefix "$L__" for branch label names.

You are right. I’ll look into this more.

May 3 2022, 1:09 PM · Restricted Project, Restricted Project

Apr 30 2022

slydiman committed rG2e7e0975c001: [NVPTX] Prefix "$L__" for branch label names (authored by slydiman).
[NVPTX] Prefix "$L__" for branch label names
Apr 30 2022, 12:56 PM · Restricted Project, Restricted Project
slydiman closed D119669: [NVPTX] Prefix "$L__" for branch label names.
Apr 30 2022, 12:55 PM · Restricted Project, Restricted Project
slydiman added inline comments to D124698: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64.
Apr 30 2022, 1:33 AM · Restricted Project, Restricted Project
slydiman updated the diff for D119669: [NVPTX] Prefix "$L__" for branch label names.
Apr 30 2022, 1:27 AM · Restricted Project, Restricted Project

Apr 29 2022

slydiman committed rG8c49ab040c67: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64 (authored by slydiman).
[NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64
Apr 29 2022, 3:34 PM · Restricted Project, Restricted Project
slydiman closed D124698: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64.
Apr 29 2022, 3:34 PM · Restricted Project, Restricted Project
slydiman requested review of D124698: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64.
Apr 29 2022, 1:56 PM · Restricted Project, Restricted Project
slydiman requested review of D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit.
Apr 29 2022, 12:27 PM · debug-info, Restricted Project, Restricted Project
slydiman added a comment to D119669: [NVPTX] Prefix "$L__" for branch label names.

I believe the problem is solved here https://reviews.llvm.org/D123702
I will check everything and resubmit this patch.

Apr 29 2022, 6:01 AM · Restricted Project, Restricted Project

Apr 28 2022

slydiman reopened D119669: [NVPTX] Prefix "$L__" for branch label names.
Apr 28 2022, 1:20 PM · Restricted Project, Restricted Project

Apr 16 2022

slydiman added inline comments to D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS.
Apr 16 2022, 8:03 AM · Restricted Project, Restricted Project

Mar 11 2022

slydiman committed rGdfeb9781557c: Fixed a roll-over on size_t in getNewUninitMemBuffer() (authored by slydiman).
Fixed a roll-over on size_t in getNewUninitMemBuffer()
Mar 11 2022, 1:18 AM · Restricted Project
slydiman closed D121399: Fixed a roll-over on size_t in getNewUninitMemBuffer().
Mar 11 2022, 1:17 AM · Restricted Project, Restricted Project

Mar 10 2022

slydiman requested review of D121399: Fixed a roll-over on size_t in getNewUninitMemBuffer().
Mar 10 2022, 11:49 AM · Restricted Project, Restricted Project

Mar 9 2022

slydiman closed D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.
Mar 9 2022, 6:33 AM · Restricted Project, Restricted Project
slydiman added a comment to D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.

Closed by commit https://github.com/llvm/llvm-project/commit/e5c1a908b36eadb59c2ec7dd1cc784e1e1fa74f8

Mar 9 2022, 6:33 AM · Restricted Project, Restricted Project
slydiman committed rGe5c1a908b36e: [llvm-dwarfdump] Avoid possible div-by-zero in debug output (authored by slydiman).
[llvm-dwarfdump] Avoid possible div-by-zero in debug output
Mar 9 2022, 6:04 AM · Restricted Project
slydiman added inline comments to D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.
Mar 9 2022, 5:44 AM · Restricted Project, Restricted Project
slydiman updated the diff for D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.
Mar 9 2022, 5:42 AM · Restricted Project, Restricted Project
slydiman requested review of D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.
Mar 9 2022, 4:47 AM · Restricted Project, Restricted Project

Mar 3 2022

slydiman abandoned D119640: [Transforms] InstCombineAddSub: Fix missing nsw/nuw flags.
Mar 3 2022, 1:56 PM · Restricted Project, Restricted Project

Feb 27 2022

slydiman abandoned D119637: [Transforms] Reassociate: Fix missing nsw/nuw flags.
Feb 27 2022, 10:07 AM · Restricted Project

Feb 22 2022

slydiman added a comment to D119643: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select.

Could you provide some details how to precommit these tests?

Feb 22 2022, 12:16 PM · Restricted Project
slydiman committed rG90a3b3109170: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select (authored by slydiman).
[Transforms] Enhance CorrelatedValuePropagation to handle both values of select
Feb 22 2022, 12:12 PM
slydiman committed rG0b302be02338: [Transforms] Pre-commit test cases for CorrelatedValuePropagation to handle… (authored by slydiman).
[Transforms] Pre-commit test cases for CorrelatedValuePropagation to handle…
Feb 22 2022, 12:12 PM
slydiman closed D119643: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select.
Feb 22 2022, 12:12 PM · Restricted Project

Feb 21 2022

slydiman added a comment to D119643: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select.

Please precommit the tests first.

Feb 21 2022, 10:36 AM · Restricted Project

Feb 20 2022

slydiman added a comment to D119643: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select.

Ping

Feb 20 2022, 9:53 AM · Restricted Project

Feb 15 2022

slydiman added a comment to D119669: [NVPTX] Prefix "$L__" for branch label names.

@slydiman please verify that clang-generated PTX with the patch does get accepted by ptxas. I'm not quite sure what went wrong here and we can't test it in clang/llvm in-tree tests as they don't have access to CUDA SDK.

Feb 15 2022, 1:26 AM · Restricted Project, Restricted Project

Feb 14 2022

slydiman added a comment to D119643: [Transforms] Enhance CorrelatedValuePropagation to handle both values of select.

It looks like your new test is based on @test5() from basic.ll, can you please add the new one next to it, precommit and rebase?

Done

Feb 14 2022, 2:35 PM · Restricted Project
slydiman committed rG885140171a76: [NVPTX] Fix NVPTXReplaceImageHandles for multiple uses of a texref (authored by slydiman).
[NVPTX] Fix NVPTXReplaceImageHandles for multiple uses of a texref
Feb 14 2022, 2:31 PM
slydiman closed D119635: [NVPTX] Fix NVPTXReplaceImageHandles for multiple uses of a texref.
Feb 14 2022, 2:31 PM · Restricted Project
slydiman committed rG6645bfa8f501: [NVPTX] Fix bug with int_nvvm_rotate_b64 when operand immediate (authored by slydiman).
[NVPTX] Fix bug with int_nvvm_rotate_b64 when operand immediate
Feb 14 2022, 2:24 PM
slydiman closed D119639: [NVPTX] Fix bug with int_nvvm_rotate_b64 when operand immediate.
Feb 14 2022, 2:24 PM · Restricted Project