Page MenuHomePhabricator

partitionSetParts from C to C++ interface.
ClosedPublic

Authored by chelini on May 23 2018, 5:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

chelini created this revision.May 23 2018, 5:12 AM

@cs15btech11044, would you like to review this patch? (Be careful, there are a couple of things that should be fixed)

Meinersbur added inline comments.May 23 2018, 12:16 PM
lib/Analysis/ScopInfo.cpp
1332 ↗(On Diff #148190)

[Nit] Unnecessary additional newline

3035 ↗(On Diff #148190)

[Nit] Unnecessary additional newline

3042 ↗(On Diff #148190)

[Nit] Please remove commented code entirely.

3049 ↗(On Diff #148190)

[Nit] Stray change

@chelini : any plans to update this patch?

chelini updated this revision to Diff 149514.Jun 1 2018, 11:24 AM

@chelini : any plans to update this patch?

Done. Could you please check that everything is ok?
Best regards,
Lorenzo Chelini

This revision is now accepted and ready to land.Jun 1 2018, 11:33 AM

Great! Could you please commit it? I cannot do that.

This revision was automatically updated to reflect the committed changes.

Done. Thanks Lorenzo!