Page MenuHomePhabricator

cs15btech11044 (SAHIL GIRISH YERAWAR)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 22 2018, 1:10 AM (69 w, 6 d)

Recent Activity

Aug 13 2018

cs15btech11044 added a comment to D50642: [IslExprBuilder] Allow 64-bit ints in hasLargeInts().

All the regression tests pass successfully.

Aug 13 2018, 9:45 AM
cs15btech11044 created D50642: [IslExprBuilder] Allow 64-bit ints in hasLargeInts().
Aug 13 2018, 9:44 AM

Aug 5 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Addressed @philip.pfaffe 's concern regarding disabling getArrayOffset().

Aug 5 2018, 12:34 PM

Aug 4 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

For Chapel Arrays with custom dimension ranges (like arr[1..4][1..4] for instance), there were two issues

  • For generating OffsetValue in the Kernel function for GPU, there wasn't any reference to the value counterpart given to expandCodeFor() in IslExprBuilder.cpp. It is fixed by passing the GlobalMap to the function.
Aug 4 2018, 3:32 AM
cs15btech11044 added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Aug 4 2018, 2:55 AM

Aug 1 2018

cs15btech11044 added a comment to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

I am following this suggestion. However, I would like to clarify something.
Suppose we are considering a 3-dimensional array named arr (Consider C language for now).
Does the offset/padding solution suggested in the previous comment model the situation where each dimension of the array has its range from 0 to some dimension size value and while accessing the array, we use some arithmetic along with the respective dimension index ( arr[i+1][2*j-1][3*k] for instance)?

Aug 1 2018, 7:20 AM

Jul 28 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Optimized the previous patch by passing only dimension Sizes and injecting LLVM-IR related to computation of block values from Dimension Sizes

Jul 28 2018, 1:50 PM
cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Changes made to this diff

  • Fixed the complementing memory allocation and index expression problems by making some design changes in ShapeInfo class. The main reason for this change is that the block values which chapel uses aren't exactly the array sizes per dimension. So there arises a need to include the parameters to ShapeInfo which corresponds to actual array sizes.
Jul 28 2018, 3:58 AM

Jul 17 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Modified getFortranArrayIds() to check over all dimensions of the array.

Jul 17 2018, 7:28 AM
cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
  • Added the changes related to IslNodeBuilder and IslExprBuilder which were using ShapeInfo related information
  • In PPCGCodeGeneration, handling of polly_array_index() has been taken care of.
  • An extra test case has been added to the GPGPU/ demonstrating the crash related to improper context generation in the SCoP.
Jul 17 2018, 4:03 AM

Jul 12 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Updated the test case for reference.

Jul 12 2018, 8:24 AM
cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Updates made in this patch:

  • There were some places which were strictly using size representation for their purpose. These failed whenever we relied on stride based representation. Some changes were made to ShapeInfo to allow flexible usage of Sizes or Shapes vector depending on their availability.
Jul 12 2018, 8:04 AM

Jul 9 2018

cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Added the minimal test case, which is causing isl_map assertion failure.

Jul 9 2018, 5:35 AM

Jul 8 2018

cs15btech11044 added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 4:21 AM
cs15btech11044 added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 3:39 AM
cs15btech11044 added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 3:15 AM
cs15btech11044 updated the diff for D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Updated this patch according to Chapel's intrinsic conventions exclusively, thus it needs to be improved upon.
Only the ScopBuilder and ScopHelper are affected by this update.

Jul 8 2018, 3:14 AM

Jul 6 2018

cs15btech11044 added a comment to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..

Next Steps:

  • There was a need to introduce a new kind of value map for this to work, a map from const SCEV * -> Value *. I hugely dislike this design, and would love to change this.
Jul 6 2018, 7:46 AM
cs15btech11044 created D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 6 2018, 7:42 AM

Jul 5 2018

cs15btech11044 added inline comments to D48874: [Polly] [WIP] Introduce ShapeInfo into polly..
Jul 5 2018, 10:52 PM · Restricted Project
cs15btech11044 created D48965: [ScopInfo] Move foldSizeConstantsToRight() to isl++.
Jul 5 2018, 5:29 AM

Jun 28 2018

cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Used for-each loop with llvm::drop_begin() in hasVariantIndex().
Removed hasVariantIndex()definition from header file and made it static.
Added %loadPolly in the test case and modified the run statement.

Jun 28 2018, 1:16 AM

Jun 27 2018

cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Outlined the loop as per @Meinersbur 's suggestion and corrected the loop header responsible for checking invariant nature of the GEP indices.

Jun 27 2018, 1:08 AM
cs15btech11044 added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 27 2018, 12:52 AM

Jun 26 2018

cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Simplified the GEP index checks by just checking invariant property at the outermost loop.

Jun 26 2018, 4:53 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Improved the patch, which now analyzes every GEP index for all the nested loops.

Jun 26 2018, 3:45 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Strengthened the condition for pattern matching and added the required comments.

Jun 26 2018, 2:27 AM

Jun 25 2018

cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Added comments in ScopHelper.cpp explaining the purpose of the new code.

Jun 25 2018, 10:39 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Removed unnecessary BB's in the test case.

Jun 25 2018, 4:48 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Addressed Philip's concerns and removed unnecessary declarations and instructions.

Jun 25 2018, 4:33 AM

Jun 22 2018

cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Addressed all the comments related to the test case.

Jun 22 2018, 10:50 AM
cs15btech11044 added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 22 2018, 9:08 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Refined the test case according to the comments.

Jun 22 2018, 7:50 AM
cs15btech11044 added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 22 2018, 7:48 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Updates in this patch:

  1. Added a test case
  2. Removed // break
  3. Added const to variables which do not change.
Jun 22 2018, 6:44 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Updates made to this diff:

  1. Addressed Phillip's concerns.
  2. Some more variable name changes.
  3. Minor updates to the fixed-point iteration approach.
Jun 22 2018, 4:11 AM

Jun 21 2018

cs15btech11044 added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 21 2018, 7:04 AM
cs15btech11044 updated the diff for D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Updates made in this patch:

  1. Implemented @philip.pfaffe 's fixed-point iteration idea to decide the invariant loads, which also solves the instability issue of the previous approach.
  2. Added Doxygen comment for the newly introduced parameter.
  3. Renamed the temporary variables according to LLVM standards.
  4. Used foreach for iterating over the invariant load set.
Jun 21 2018, 6:19 AM

Jun 11 2018

cs15btech11044 created D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 11 2018, 7:35 AM

May 27 2018

cs15btech11044 updated the summary of D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.
May 27 2018, 11:40 PM
cs15btech11044 updated the diff for D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

Updates made to this differential:

  1. Removed manage(release) pattern in this diff
  2. Replaced auto keyword with explicit type wherever necessary.
May 27 2018, 11:18 PM
cs15btech11044 created D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.
May 27 2018, 11:00 PM

May 21 2018

cs15btech11044 accepted D47102: createNextIterationMap from C to C++ interface.

Thank you for letting me review this patch.
LGTM. @grosser, could you please commit this patch (I do not have commit rights as of now)?

May 21 2018, 12:16 AM · Restricted Project

May 16 2018

cs15btech11044 added a comment to D46935: [ScopInfo] Remove usage of isl_set_n_basic_set().

Yes, @philip.pfaffe.
I do not currently have commit access as of now.
Could you please commit it on my behalf with an annotation mentioning the contributor?

May 16 2018, 7:00 AM
cs15btech11044 updated the diff for D46935: [ScopInfo] Remove usage of isl_set_n_basic_set().
May 16 2018, 5:01 AM
cs15btech11044 added inline comments to D46935: [ScopInfo] Remove usage of isl_set_n_basic_set().
May 16 2018, 4:49 AM
cs15btech11044 created D46935: [ScopInfo] Remove usage of isl_set_n_basic_set().
May 16 2018, 4:33 AM

May 9 2018

cs15btech11044 added a comment to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Yes, it is fine.

May 9 2018, 9:08 AM

May 7 2018

cs15btech11044 added a comment to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

This patch has been quite inactive for some time.
Are there any issues with this diff which are preventing it from getting committed to Polly codebase?

May 7 2018, 1:51 PM

Apr 21 2018

cs15btech11044 updated the diff for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Updates in the new diff:

  1. Attached a test case run-time-check-many-piecewise-aliasing.ll with appropriate checks.
  2. Incorporating these changes on the latest version of Polly present, thereby updating the diff.
  3. Summary of the changes in this patch
Apr 21 2018, 2:02 AM

Apr 20 2018

cs15btech11044 added a comment to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

I think the given test case is sufficient enough for this fix. When I tried to run this test case manually over opt, after applying Set.simple_hull(), it gave exactly the same reduced set as mentioned in the previous comment.

Apr 20 2018, 11:35 AM

Apr 17 2018

cs15btech11044 set the repository for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess() to rPLO Polly.
Apr 17 2018, 11:00 AM

Apr 16 2018

cs15btech11044 updated the diff for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Updates in this patch:

  1. Removed the unnecessary alias reference of Set in calculateMinMaxAccess
  2. Function signature of buildMinMaxAccess has been changed, removing reference to a set.
  3. Removing MaxDisjunctsInDomain condition
  4. Calling remove_divs() on Set before polly::simplify()
Apr 16 2018, 10:16 AM
cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 16 2018, 1:21 AM
cs15btech11044 added a comment to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 16 2018, 12:19 AM

Apr 14 2018

cs15btech11044 updated the diff for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Changes made to this new patch:

  1. Modified variable names according to LLVM coding standards.
  2. Used RunTimeChecksMaxAccessDisjuncts for the initial check.
  3. Modified the assertion according to @Meinersbur's second suggestion.
Apr 14 2018, 11:58 AM

Apr 13 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 13 2018, 10:09 AM

Apr 12 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 12 2018, 1:42 AM

Apr 11 2018

cs15btech11044 updated the diff for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Addressing the previous suggestions as well as incorporating some of mine.

Apr 11 2018, 2:26 PM

Apr 10 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 10 2018, 4:27 AM

Apr 9 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 9 2018, 3:09 AM

Apr 5 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 5 2018, 11:49 PM
cs15btech11044 updated the diff for D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

Implementing the changes suggested by @Meinersbur
List of failing regression tests:

Apr 5 2018, 11:35 PM
cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 5 2018, 11:30 PM

Apr 1 2018

cs15btech11044 added inline comments to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Apr 1 2018, 2:28 AM

Mar 29 2018

cs15btech11044 added a comment to D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().

List of failing regression tests:

Mar 29 2018, 3:04 PM
cs15btech11044 created D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess().
Mar 29 2018, 3:00 PM

Mar 21 2018

cs15btech11044 added a comment to D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..

Hi all,
Sorry for this delayed response

Mar 21 2018, 5:27 AM

Mar 17 2018

cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 17 2018, 12:40 PM

Mar 16 2018

cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 16 2018, 9:54 AM
cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 16 2018, 9:47 AM
cs15btech11044 added reviewers for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark.: Ayal, anemet.
Mar 16 2018, 1:32 AM
cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 16 2018, 1:19 AM
cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 16 2018, 12:18 AM

Mar 14 2018

cs15btech11044 updated the diff for D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 14 2018, 8:01 AM

Mar 3 2018

cs15btech11044 created D44067: [LV] Improving "Control-Flow-Select" Vectorization remark..
Mar 3 2018, 12:03 AM