Page MenuHomePhabricator

[AArch64] Correct inline assembly test case for S modifier [NFC]
ClosedPublic

Authored by peter.smith on May 16 2018, 2:49 AM.

Details

Summary

The existing test for the AArch64 constraint S uses the A and L modifiers. These modifiers were implemented in the original AArch64 backend but were not carried forward to the merged backend. The A is associated with ADRP and does nothing, the L is associated with :lo12: . Given that A and L are not supported by GCC and not supported by the new implementation of constraint S in LLVM (see D46745) I've altered the test to put :lo12: directly in the string so that A and L are not needed. A recent use of S in the linux kernel can be found at https://github.com/torvalds/linux/commit/44a497abd621a71c645f06d3d545ae2f46448830

Diff Detail

Repository
rC Clang

Event Timeline

peter.smith created this revision.May 16 2018, 2:49 AM
manojgupta accepted this revision.May 16 2018, 3:30 PM
This revision is now accepted and ready to land.May 16 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.