This is an archive of the discontinued LLVM Phabricator instance.

[llvm-mca] Move the RegisterFile class into its own translation unit. NFC
ClosedPublic

Authored by mattd on May 15 2018, 4:33 PM.

Diff Detail

Event Timeline

mattd created this revision.May 15 2018, 4:33 PM
courbet accepted this revision.May 16 2018, 1:29 AM

yay, smaller files :)

This revision is now accepted and ready to land.May 16 2018, 1:29 AM
andreadb accepted this revision.May 16 2018, 1:33 AM

If the goal is to make the current DispatchUnit a DispatchStage, then this makes sense.

A couple of minor nits. Otherwise it looks good to me.

tools/llvm-mca/Dispatch.h
22

This include should stay in this file.

tools/llvm-mca/RegisterFile.h
23

This include file is not needed.
Instead, you should include llvm/MC/MCSchedule.h.

mattd updated this revision to Diff 147112.May 16 2018, 9:27 AM
mattd marked 2 inline comments as done.

Corrected the #include directives.

mattd added a comment.May 16 2018, 9:28 AM

Thanks for the reviews.

This revision was automatically updated to reflect the committed changes.