A suggestion from @JDevlieghere means that we need to pass in a callback that takes an Error rather than a string into the getLineTableForUnit. This corresponds to D46831.
Details
Details
Diff Detail
Diff Detail
- Repository
- rLLD LLVM Linker
Event Timeline
Comment Actions
LGTM with a nit.
ELF/InputFiles.cpp | ||
---|---|---|
134 | Since it is a variable, it should be uppercase: WarnForError I would name it simpler though. For example - Report. |
Since it is a variable, it should be uppercase: WarnForError
I would name it simpler though. For example - Report.