This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Change arguments to match D46831
ClosedPublic

Authored by jhenderson on May 14 2018, 7:36 AM.

Details

Summary

A suggestion from @JDevlieghere means that we need to pass in a callback that takes an Error rather than a string into the getLineTableForUnit. This corresponds to D46831.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

jhenderson created this revision.May 14 2018, 7:36 AM
grimar accepted this revision.May 14 2018, 8:05 AM

LGTM with a nit.

ELF/InputFiles.cpp
134

Since it is a variable, it should be uppercase: WarnForError

I would name it simpler though. For example - Report.

This revision is now accepted and ready to land.May 14 2018, 8:05 AM
This revision was automatically updated to reflect the committed changes.