[ELF] Change arguments to match D46831

[jhenderson]

Summary

A suggestion from @JDevlieghere means that we need to pass in a callback that takes an Error rather than a string into the getLineTableForUnit. This corresponds to D46831.

[grimar]

LGTM with a nit.

ELF/InputFiles.cpp

134 ↗

(On Diff #146607)

Since it is a variable, it should be uppercase: WarnForError

I would name it simpler though. For example - Report.

lld/trunk/ELF/InputFiles.cpp

 template <class ELFT> void ObjFile<ELFT>::initializeDwarf() {
   Dwarf = llvm::make_unique<DWARFContext>(make_unique<LLDDwarfObj<ELFT>>(this));
   const DWARFObject &Obj = Dwarf->getDWARFObj();
   DwarfLine.reset(new DWARFDebugLine);
   DWARFDataExtractor LineData(Obj, Obj.getLineSection(), Config->IsLE,
                               Config->Wordsize);
 
   for (std::unique_ptr<DWARFCompileUnit> &CU : Dwarf->compile_units()) {
+    auto Report = [](Error Err) {
+      handleAllErrors(std::move(Err),
+                      [](ErrorInfoBase &Info) { warn(Info.message()); });
+    };
     Expected<const DWARFDebugLine::LineTable *> ExpectedLT =
-        Dwarf->getLineTableForUnit(CU.get(), warn);
+        Dwarf->getLineTableForUnit(CU.get(), Report);
     const DWARFDebugLine::LineTable *LT = nullptr;
     if (ExpectedLT)
       LT = *ExpectedLT;
     else
-      handleAllErrors(ExpectedLT.takeError(),
-                      [](ErrorInfoBase &Err) { warn(Err.message()); });
+      Report(ExpectedLT.takeError());
     if (!LT)
       continue;
     LineTables.push_back(LT);
 
     // Loop over variable records and insert them to VariableLoc.
     for (const auto &Entry : CU->dies()) {
       DWARFDie Die(CU.get(), &Entry);
       // Skip all tags that are not variables.