This is an archive of the discontinued LLVM Phabricator instance.

Do not link with -ldl in NetBSD/ASan tests
ClosedPublic

Authored by krytarowski on May 10 2018, 12:18 PM.

Reviewers

Commits

Summary

The dlopen(3) features on NetBSD are in libc.

vitalybuka added inline comments.

test/asan/lit.cfg
51	config.host_os not in ['FreeBSD', 'NetBSD']

This revision is now accepted and ready to land.May 17 2018, 4:42 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

asan/

3 lines

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines	if default_asan_opts_str:
config.environment['ASAN_OPTIONS'] = default_asan_opts_str		config.environment['ASAN_OPTIONS'] = default_asan_opts_str
default_asan_opts_str += ':'		default_asan_opts_str += ':'
config.substitutions.append(('%env_asan_opts=',		config.substitutions.append(('%env_asan_opts=',
'env ASAN_OPTIONS=' + default_asan_opts_str))		'env ASAN_OPTIONS=' + default_asan_opts_str))

# Setup source root.		# Setup source root.
config.test_source_root = os.path.dirname(__file__)		config.test_source_root = os.path.dirname(__file__)

# There is no libdl on FreeBSD.		if config.host_os not in ['FreeBSD', 'NetBSD']:
		vitalybukaUnsubmitted Not Done Reply Inline Actions config.host_os not in ['FreeBSD', 'NetBSD'] vitalybuka: ``` config.host_os not in ['FreeBSD', 'NetBSD'] ```
if config.host_os != 'FreeBSD':
libdl_flag = "-ldl"		libdl_flag = "-ldl"
else:		else:
libdl_flag = ""		libdl_flag = ""

# GCC-ASan doesn't link in all the necessary libraries automatically, so		# GCC-ASan doesn't link in all the necessary libraries automatically, so
# we have to do it ourselves.		# we have to do it ourselves.
if config.compiler_id == 'GNU':		if config.compiler_id == 'GNU':
extra_link_flags = ["-pthread", "-lstdc++", libdl_flag]		extra_link_flags = ["-pthread", "-lstdc++", libdl_flag]
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines