This is an archive of the discontinued LLVM Phabricator instance.

Differential D46700

[ThinLTO] Add testing of new summary index format to a couple CFI tests
ClosedPublic

Authored by tejohnson on May 10 2018, 8:40 AM.

Details

Reviewers
pcc
Commits
rGe2e630b01bdb: [ThinLTO] Add testing of new summary index format to a couple CFI tests
rC333966: [ThinLTO] Add testing of new summary index format to a couple CFI tests
rL333966: [ThinLTO] Add testing of new summary index format to a couple CFI tests
Summary

Adds testing of combined index summary entries in disassembly format
to CFI tests that were already testing the bitcode format.

Depends on D46699.

Diff Detail

Event Timeline

tejohnson created this revision.May 10 2018, 8:40 AM
Herald added subscribers: eraman, inglorion, mehdi_amini. · View Herald TranscriptMay 10 2018, 8:40 AM
tejohnson updated this revision to Diff 146836.May 15 2018, 8:22 AM

Update tests for changes to D46699

Harbormaster completed remote builds in B18120: Diff 146836.May 15 2018, 8:22 AM
tejohnson updated this revision to Diff 148740.May 26 2018, 4:11 PM

Update tests so they won't get bot failures (don't try to match path, module
hash).

Ping - this can go in now that D46699 is in.

Harbormaster completed remote builds in B18627: Diff 148740.May 26 2018, 4:11 PM
tejohnson added a comment.Jun 4 2018, 2:21 PM

ping

Herald added a subscriber: steven_wu. · View Herald TranscriptJun 4 2018, 2:21 PM
pcc accepted this revision.Jun 4 2018, 2:33 PM

LGTM

This revision is now accepted and ready to land.Jun 4 2018, 2:33 PM
Closed by commit rL333966: [ThinLTO] Add testing of new summary index format to a couple CFI tests (authored by tejohnson). · Explain WhyJun 4 2018, 4:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 4 2018, 4:09 PM

Revision Contents

Diff 146139

test/CodeGen/thinlto-distributed-cfi-devirt.ll

Show All 23 Lines
; RUN: llvm-bcanalyzer -dump %t.o.thinlto.bc | FileCheck %s ; RUN: llvm-bcanalyzer -dump %t.o.thinlto.bc | FileCheck %s
; CHECK-LABEL: <GLOBALVAL_SUMMARY_BLOCK ; CHECK-LABEL: <GLOBALVAL_SUMMARY_BLOCK
; CHECK: <TYPE_ID op0=0 op1=6 op2=4 op3=7 op4=0 op5=0 op6=0 op7=0 op8=0 op9=2 op10=6 op11=0 op12=0 op13=8 op14=1 op15=6 op16=9 op17=0/> ; CHECK: <TYPE_ID op0=0 op1=6 op2=4 op3=7 op4=0 op5=0 op6=0 op7=0 op8=0 op9=2 op10=6 op11=0 op12=0 op13=8 op14=1 op15=6 op16=9 op17=0/>
; CHECK-LABEL: </GLOBALVAL_SUMMARY_BLOCK ; CHECK-LABEL: </GLOBALVAL_SUMMARY_BLOCK
; CHECK-LABEL: <STRTAB_BLOCK ; CHECK-LABEL: <STRTAB_BLOCK
; CHECK: blob data = '_ZTS1A_ZN1A1nEi' ; CHECK: blob data = '_ZTS1A_ZN1A1nEi'
; CHECK-LABEL: </STRTAB_BLOCK ; CHECK-LABEL: </STRTAB_BLOCK
; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s --check-prefix=CHECK-DIS
; CHECK-DIS: ^0 = module: (path: {{.*}}/tools/clang/test/CodeGen/Output/thinlto-distributed-cfi-devirt.ll.tmp.o, hash: 10602563178837352427)
; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function: (module: ^0, flags: (linkage: extern, notEligibleToImport: 0, live: 1, dsoLocal: 0), insts: 18, typeIdInfo: (typeTests: (^2), typeCheckedLoadVCalls: (vFuncId: (^2, offset: 8), vFuncId: (^2, offset: 0))))))
; CHECK-DIS: ^2 = typeid: (name: _ZTS1A, summary: (typeTestRes: (kind: allOnes, sizeM1BitWidth: 7), wpdResolutions: ((offset: 0, wpdRes: (kind: branchFunnel)), (offset: 8, wpdRes: (kind: singleImpl, singleImplName: _ZN1A1nEi))))) ; guid = 7004155349499253778
; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \ ; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \
; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \ ; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \
; RUN: -emit-llvm -o - -x ir %t.o | FileCheck %s --check-prefixes=CHECK-IR ; RUN: -emit-llvm -o - -x ir %t.o | FileCheck %s --check-prefixes=CHECK-IR
; Check that backend does not fail generating native code. ; Check that backend does not fail generating native code.
; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \ ; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \
; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \ ; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \
; RUN: -o %t.native.o -x ir %t.o ; RUN: -o %t.native.o -x ir %t.o
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

test/CodeGen/thinlto-distributed-cfi.ll

Show All 14 Lines
; RUN: llvm-bcanalyzer -dump %t.o.thinlto.bc | FileCheck %s ; RUN: llvm-bcanalyzer -dump %t.o.thinlto.bc | FileCheck %s
; CHECK-LABEL: <GLOBALVAL_SUMMARY_BLOCK ; CHECK-LABEL: <GLOBALVAL_SUMMARY_BLOCK
; CHECK: <TYPE_ID op0=0 op1=6 op2=3 op3=0 op4=0 op5=0 op6=0 op7=0/> ; CHECK: <TYPE_ID op0=0 op1=6 op2=3 op3=0 op4=0 op5=0 op6=0 op7=0/>
; CHECK-LABEL: </GLOBALVAL_SUMMARY_BLOCK ; CHECK-LABEL: </GLOBALVAL_SUMMARY_BLOCK
; CHECK-LABEL: <STRTAB_BLOCK ; CHECK-LABEL: <STRTAB_BLOCK
; CHECK: blob data = '_ZTS1A' ; CHECK: blob data = '_ZTS1A'
; CHECK-LABEL: </STRTAB_BLOCK ; CHECK-LABEL: </STRTAB_BLOCK
; RUN: llvm-dis %t.o.thinlto.bc -o - | FileCheck %s --check-prefix=CHECK-DIS
; CHECK-DIS: ^0 = module: (path: {{.*}}/tools/clang/test/CodeGen/Output/thinlto-distributed-cfi.ll.tmp.o, hash: 8535905718600812794)
; CHECK-DIS: ^1 = gv: (guid: 8346051122425466633, summaries: (function: (module: ^0, flags: (linkage: extern, notEligibleToImport: 0, live: 1, dsoLocal: 0), insts: 7, typeIdInfo: (typeTests: (^2)))))
; CHECK-DIS: ^2 = typeid: (name: _ZTS1A, summary: (typeTestRes: (kind: single, sizeM1BitWidth: 0))) ; guid = 7004155349499253778
; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \ ; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \
; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \ ; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \
; RUN: -emit-llvm -o - -x ir %t.o | FileCheck %s --check-prefixes=CHECK-IR ; RUN: -emit-llvm -o - -x ir %t.o | FileCheck %s --check-prefixes=CHECK-IR
; Ensure that backend does not fail generating native code. ; Ensure that backend does not fail generating native code.
; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \ ; RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu \
; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \ ; RUN: -emit-obj -fthinlto-index=%t.o.thinlto.bc \
; RUN: -o %t.native.o -x ir %t.o ; RUN: -o %t.native.o -x ir %t.o
Show All 37 Lines