This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Allow signature of entry function to be flexible
ClosedPublic

Authored by sbc100 on May 8 2018, 11:54 AM.

Details

Summary

Since we a no longer using this function for the wasm start
section we don't actually care what its signature is.

Currently we expect to be (void) -> (void) which causes linker
warnings for people trying to do things like --entry=main.

This means that the entry point now joins the list of undefined
functions that are not effected by the --allow-undefined
flag. If you want an undefined entry you now need to pass
--no-entry.

Event Timeline

sbc100 created this revision.May 8 2018, 11:54 AM
sbc100 updated this revision to Diff 145770.May 8 2018, 1:36 PM
  • don't allow undefined entry
sbc100 retitled this revision from [WebAssembly] Allow signautre of entry function to be flexible to [WebAssembly] Allow signature of entry function to be flexible.May 8 2018, 1:37 PM
sbc100 edited the summary of this revision. (Show Details)
sbc100 edited the summary of this revision. (Show Details)May 8 2018, 1:39 PM
sbc100 updated this revision to Diff 145771.May 8 2018, 1:43 PM
  • cleanup
ruiu accepted this revision.May 14 2018, 3:58 PM

LGTM

This revision is now accepted and ready to land.May 14 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.