Page MenuHomePhabricator

add suffix to report file name
AcceptedPublic

Authored by WallStProg on May 7 2018, 1:29 PM.

Details

Reviewers
kcc
vitalybuka
Group Reviewers
Restricted Project
Summary

For those using a GUI, it can be very helpful to have a particular suffix appended to the report file name, so it can be opened with a double-click.

(see also: https://github.com/google/sanitizers/issues/951)

Diff Detail

Event Timeline

WallStProg created this revision.May 7 2018, 1:29 PM
kcc added a comment.May 7 2018, 2:47 PM

I am a bit reluctant to add more flags, but this change seems to be pretty small, so probably ok.
Could you please add a test?
(Something similar to test/asan/TestCases/verbose-log-path_test.cc, but in test/sanitizer_common)

Could you please add a test?
(Something similar to test/asan/TestCases/verbose-log-path_test.cc, but in test/sanitizer_common)

OK -- give me a couple days to figure out the test infrastructure. AFAICT verbose-log-path_test.cc isn't even being built in my env.

Well, I've added a test pgm but the only way I've been able to is within asan (using monkey-see, monkey-do approach ;-) The test is modeled on existing verbose-log-path_test, and appears to run successfully with "make check-all".

Getting this into sanitizer-common is way beyond what I can hope to do at this point. If you can provide some pointers on writing tests I can take another shot at it (although frankly I'd much rather not ;-)

Hope this is sufficient -- pls let me know.

vitalybuka accepted this revision as: vitalybuka.May 17 2018, 1:35 PM
This revision is now accepted and ready to land.May 17 2018, 1:35 PM
filcab added a subscriber: filcab.Jul 3 2018, 4:21 AM

Check out test/sanitizer_common/TestCases/options-include.cc as an example you can use to adapt yours.
You might only need to change env_asan_opts to env_tool_opts to get it to work.

Instead of having a positive FIXME, please change it to a negative: windows and android don't support X (which is what the line below is doing).

WallStProg added a comment.EditedAug 22 2018, 3:50 AM

Check out test/sanitizer_common/TestCases/options-include.cc as an example you can use to adapt yours.
You might only need to change env_asan_opts to env_tool_opts to get it to work.

Instead of having a positive FIXME, please change it to a negative: windows and android don't support X (which is what the line below is doing).

Sorry, but I have no idea what all those decorations are, nor do I have any desire to learn how to shave that particular yak. The test program was simply copied and pasted from verbose-log-path-test.cc, so any comment should apply to it as well.

Hopefully this will make into trunk at some point -- it's quite useful, and I'd love to be able to stop patching my local builds.