Here we introduce intrinsic fast math sub flag mapping, fma and interior expression fast math sub flag mapping as well as cmp and others with tests to exemplify where flags propagate and where they do not.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I'm still nervous about doing more than 1 thing in the same patch. I'd like to focus on the SelectionDAGBuilder part first. We should have tests now that verify at least some of those diffs. Can you split that change off?
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | ||
---|---|---|
5481–5499 | I don't like that we're going to miss FMF propagation for all of these intrinsics. I'd like to get propagation done in one place and completely, so we don't have to keep adding code every time there's a new intrinsic. See D37686 for an alternate idea. |
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | ||
---|---|---|
5481–5499 | I had been considering moving it to setValue... |
Comment Actions
This review will still contain the propagation code, but will be stale for a bit while its code is split up into intervening reviews. Stay tuned...
I don't like that we're going to miss FMF propagation for all of these intrinsics. I'd like to get propagation done in one place and completely, so we don't have to keep adding code every time there's a new intrinsic. See D37686 for an alternate idea.