Page MenuHomePhabricator

intrinsic management for fast math sub flags
AbandonedPublic

Authored by mcberg2017 on May 7 2018, 5:02 PM.

Details

Reviewers
spatel
wristow
Summary

This patch addresses handling fast math flags for intrinsics and is malleable enough to provide support for new intrinsics with little or no changes after the fact.

Diff Detail

Event Timeline

mcberg2017 created this revision.May 7 2018, 5:02 PM
mcberg2017 added inline comments.
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
5542

Minor clean up on the braces, it will be in the next upload.

mcberg2017 updated this revision to Diff 145599.May 7 2018, 5:14 PM

Minor update with some cleanup

Updated for recent changes in the scope of this review...

updated to use the convenience function in r332155

Any other comments on these changes? It would be great to proceed.

Any other comments on these changes? It would be great to proceed.

I'm still not sold on this approach. IIUC, we're still missing propagation on fcmp, vector reduce, and libcalls.

As I mentioned in D46483, D37686 had a more complete implementation. I drafted a much simpler version of that patch locally. Let me add some tests and clean that up a bit and see if that looks better to you.

mcberg2017 abandoned this revision.May 14 2018, 4:58 PM