This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] Add support for optimization remarks to thinBackend
ClosedPublic

Authored by tejohnson on May 2 2018, 8:08 PM.

Details

Summary

Support was added to the regular LTO backend, but not thinBackend.
This patch adds that support.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.May 2 2018, 8:08 PM
pcc accepted this revision.May 3 2018, 11:42 AM

LGTM

Maybe consider making finalizeOptimizationRemarks return an llvm::Error so that we can return from thinBackend with return finalizeOptimizationRemarks(...).

This revision is now accepted and ready to land.May 3 2018, 11:42 AM
In D46376#1086811, @pcc wrote:

LGTM

Maybe consider making finalizeOptimizationRemarks return an llvm::Error so that we can return from thinBackend with return finalizeOptimizationRemarks(...).

Good idea, done.

tejohnson updated this revision to Diff 145085.May 3 2018, 1:27 PM

Address comments

This revision was automatically updated to reflect the committed changes.