This is an archive of the discontinued LLVM Phabricator instance.

[MCA][NFC] Lift the logic of the RetireControlUnit from the Dispatch translation unit into its own translation unit.
ClosedPublic

Authored by mattd on May 1 2018, 2:21 PM.

Details

Summary

The logic remains the same. Eventually, I see the RCU acting as its own separate stage in the instruction pipeline.

Diff Detail

Event Timeline

mattd created this revision.May 1 2018, 2:21 PM
andreadb accepted this revision.May 1 2018, 2:46 PM

The patch LGTM. I only have a few minor comments (see below).

RetireControlUnit.h
25

I noticed that you didn’t copy the comment at line 158 in the old Dispatch.h. Could you please add it back?

39

This comment should be improved.

40

This is probably my fault. You should remove the bogus “retired.” statement. Also, please remove the statement after it since it repeats what is written at line 25.

This revision is now accepted and ready to land.May 1 2018, 2:46 PM
mattd updated this revision to Diff 144801.May 1 2018, 3:14 PM
mattd marked 3 inline comments as done.
  • Reword and cleanup the RUToken comment.
  • Restore a comment I removed from RCU in the previous commit.

Next time, please remember to add llvm-commits to the subscribers list. Otherwise, your patch would not appear on the mailing list.

LGTM. Thanks Matt!

This revision was automatically updated to reflect the committed changes.