Page MenuHomePhabricator

[OMPT] Fix thread_num for implicit_task_end callbacks in nested parallel regions
ClosedPublic

Authored by sconvent on Apr 30 2018, 4:01 AM.

Details

Summary

implicit_task_end callbacks in nested parallel regions did not always give the correct thread_num, since the inner parallel region may have already been finalized.
Now, the thread_num is stored at the beginning of the implicit task and retrieved at the end, whenever necessary.

A testcase was added as well.

Diff Detail

Repository
rL LLVM

Event Timeline

sconvent created this revision.Apr 30 2018, 4:01 AM
sconvent updated this revision to Diff 144534.Apr 30 2018, 4:03 AM

Remove formatting change unrelated to this revision.

hbae added a comment.May 1 2018, 2:06 PM

The change looks good to me.

This revision is now accepted and ready to land.May 7 2018, 5:43 AM
This revision was automatically updated to reflect the committed changes.