Page MenuHomePhabricator

sconvent (Simon Convent)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2017, 12:47 AM (187 w, 2 d)

Recent Activity

Sep 10 2018

sconvent updated the diff for D50774: [OMPT] Update types according to TR7.

Moved lock calls out of OMPT code

Sep 10 2018, 1:18 AM

Aug 15 2018

sconvent updated the diff for D50774: [OMPT] Update types according to TR7.

The removal of the idle callback was done in D48362 and is removed from this Patch.

Aug 15 2018, 7:07 AM
sconvent updated the summary of D50774: [OMPT] Update types according to TR7.
Aug 15 2018, 6:44 AM
sconvent reclaimed D48362: [OMPT] Remove OMPT idle callback.
Aug 15 2018, 6:42 AM
sconvent abandoned D48362: [OMPT] Remove OMPT idle callback.
Aug 15 2018, 6:33 AM
sconvent created D50774: [OMPT] Update types according to TR7.
Aug 15 2018, 6:33 AM

Aug 1 2018

sconvent created D50140: [OMPT] Fix taskloop testcase scheduling effects.
Aug 1 2018, 6:05 AM

Jul 16 2018

sconvent created D49373: [OMPT] Print two more addresses in print_fuzzy_address_block().
Jul 16 2018, 6:46 AM

Jul 11 2018

sconvent created D49181: [OMPT] Adapt OMPT callback structure for tasks to handle untied tasks correctly (+ adapt testcase).
Jul 11 2018, 6:22 AM

Jul 4 2018

sconvent created D48932: [OMPT] Add synchronization to threads_nested.c testcase.
Jul 4 2018, 5:31 AM

Jun 25 2018

sconvent updated the diff for D48282: [OMPT] Use alloca() to force availability of frame pointer .

Add comment explaining the use of alloca()

Jun 25 2018, 2:06 AM
sconvent updated the diff for D48282: [OMPT] Use alloca() to force availability of frame pointer .

Use alloca() to force availability of frame pointer

Jun 25 2018, 1:58 AM

Jun 20 2018

sconvent created D48362: [OMPT] Remove OMPT idle callback.
Jun 20 2018, 5:30 AM

Jun 18 2018

sconvent created D48282: [OMPT] Use alloca() to force availability of frame pointer .
Jun 18 2018, 7:24 AM
sconvent updated the diff for D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

Add a testcase that calls the runtime entry points when OMPT is not enabled.

Jun 18 2018, 4:38 AM

Jun 13 2018

sconvent updated the diff for D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

Add check to ompt_get_state()

Jun 13 2018, 6:59 AM
sconvent created D48124: [OMPT] Add tests for runtime entry points from non-OpenMP threads.
Jun 13 2018, 6:49 AM

Jun 11 2018

sconvent added a comment to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

taskloop is actually a tasking construct and explicitly no worksharing construct. So, please move the test in the task directory.

Jun 11 2018, 5:49 AM
sconvent updated the diff for D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

Add support for OMPT return addresses.
Also test them.

Jun 11 2018, 5:44 AM
sconvent updated the diff for D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

Move ompt_enabled.enabled checks out of internal functions

Jun 11 2018, 2:12 AM

Jun 6 2018

sconvent created D47824: [OMPT] Add testcases for thread_begin and thread_end callbacks.
Jun 6 2018, 6:50 AM
sconvent updated the diff for D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

Use a stride of 3 in testcase loop

Jun 6 2018, 6:14 AM
sconvent added inline comments to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.
Jun 6 2018, 6:05 AM
sconvent updated the diff for D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

Use tc for the iteration count

Jun 6 2018, 6:04 AM
sconvent added inline comments to D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.
Jun 6 2018, 5:30 AM
sconvent added inline comments to D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.
Jun 6 2018, 5:08 AM
sconvent updated the diff for D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.

Address Jonas' comments:

Jun 6 2018, 5:07 AM

Jun 4 2018

sconvent created D47717: [OMPT] Make sure that OMPT is enabled in runtime entry points that access internals of the runtime.
Jun 4 2018, 7:11 AM
sconvent updated the diff for D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.

Use kmpc_omp_task() instead of changing kmp_omp_task().

Jun 4 2018, 6:55 AM
sconvent created D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase.
Jun 4 2018, 5:42 AM

Apr 30 2018

sconvent updated the diff for D46260: [OMPT] Fix thread_num for implicit_task_end callbacks in nested parallel regions.

Remove formatting change unrelated to this revision.

Apr 30 2018, 4:05 AM
sconvent created D46260: [OMPT] Fix thread_num for implicit_task_end callbacks in nested parallel regions.
Apr 30 2018, 4:01 AM

Mar 7 2018

sconvent updated the diff for D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.

Fix uninitialized step count

Mar 7 2018, 12:33 AM

Mar 1 2018

sconvent updated the diff for D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.

Implement suggestions

Mar 1 2018, 2:03 AM

Feb 28 2018

sconvent updated the diff for D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.

Reformat

Feb 28 2018, 2:51 AM
sconvent updated the diff for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

Reformat using git-clang-format
Applying clang-format to callback.h does not improve readability

Feb 28 2018, 12:46 AM

Feb 22 2018

sconvent updated the diff for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

Fix small copy-and-paste mistake

Feb 22 2018, 4:03 AM
sconvent updated the diff for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

Update Formatting

Feb 22 2018, 4:00 AM

Feb 21 2018

sconvent updated the diff for D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.

Fix indentation

Feb 21 2018, 5:56 AM
sconvent updated the summary of D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.
Feb 21 2018, 5:07 AM
sconvent created D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.
Feb 21 2018, 5:07 AM

Feb 15 2018

sconvent updated the diff for D41942: [OMPT] Add interoperability testcase.

Add some comments to checks and reformat as suggested

Feb 15 2018, 3:24 AM

Feb 14 2018

sconvent updated the diff for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

Check task_ids in task_types.c testcase

Feb 14 2018, 6:10 AM
sconvent added inline comments to D42162: [OMPT] Update api_calls testcase.
Feb 14 2018, 4:45 AM
sconvent updated the diff for D42162: [OMPT] Update api_calls testcase.

Check ompt_get_partition_place_nums().
Fix small bug in implementation of ompt_get_partition_place_nums(): return correct length.

Feb 14 2018, 4:43 AM
sconvent updated the diff for D42169: [OMPT] Formatting.

Exclude formatting of ompt_try_start_tool

Feb 14 2018, 3:32 AM
sconvent updated the diff for D41942: [OMPT] Add interoperability testcase.

Implemented suggestions

Feb 14 2018, 2:54 AM

Jan 25 2018

sconvent retitled D42472: [OMPT] Fix ompt_get_task_info() and add tests for it from [OMPT] Also test ompt_get_task_info() in task_types.c testcase to [OMPT] Fix ompt_get_task_info() and add tests for it.
Jan 25 2018, 4:03 AM
sconvent updated the summary of D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.
Jan 25 2018, 3:36 AM
sconvent created D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase.
Jan 25 2018, 1:33 AM

Jan 24 2018

sconvent abandoned D42470: [OMPT] Set thread_num in ompt_get_task_info().
Jan 24 2018, 6:28 AM
sconvent updated the diff for D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.

Merge D42470 into this revision

Jan 24 2018, 6:28 AM
sconvent created D42472: [OMPT] Fix ompt_get_task_info() and add tests for it.
Jan 24 2018, 5:48 AM
sconvent created D42470: [OMPT] Set thread_num in ompt_get_task_info().
Jan 24 2018, 5:08 AM

Jan 17 2018

sconvent updated the diff for D41942: [OMPT] Add interoperability testcase.

Implemented suggestions

Jan 17 2018, 5:35 AM
sconvent created D42169: [OMPT] Formatting.
Jan 17 2018, 5:15 AM
sconvent added a comment to D41904: [OMPT] Add tool_not_available testcase.

Hmm, can we also somehow test that the runtime continues searching for a tool in that case? For example having OMP_TOOL_LIBRARIES with a tool that has no ompt_start_tool, one that returns NULL and a final one that does activate OMPT?

Jan 17 2018, 4:52 AM
sconvent updated the diff for D41904: [OMPT] Add tool_not_available testcase.

Use omp_control_tool for an additional check

Jan 17 2018, 4:51 AM
sconvent created D42166: [OMPT] Add tool_available_search testcase.
Jan 17 2018, 4:51 AM
sconvent updated the diff for D42162: [OMPT] Update api_calls testcase.
Jan 17 2018, 2:12 AM
sconvent created D42162: [OMPT] Update api_calls testcase.
Jan 17 2018, 12:31 AM

Jan 11 2018

sconvent created D41942: [OMPT] Add interoperability testcase.
Jan 11 2018, 2:52 AM
sconvent updated the diff for D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.

Added testcase

Jan 11 2018, 2:31 AM

Jan 10 2018

sconvent updated the summary of D41904: [OMPT] Add tool_not_available testcase.
Jan 10 2018, 5:33 AM
sconvent created D41904: [OMPT] Add tool_not_available testcase.
Jan 10 2018, 5:32 AM
sconvent updated the diff for D41176: [OMPT] Fix ompt_task_data handling in implicit barriers.

Added reference to reported issue in comments

Jan 10 2018, 3:46 AM
sconvent updated the diff for D41182: [OMPT] Add Workaround for Intel Compiler Bug.
Jan 10 2018, 3:41 AM
sconvent updated the summary of D41896: [OMPT] Use fuzzy return addresses in lock testcases .
Jan 10 2018, 3:37 AM
sconvent updated the summary of D41896: [OMPT] Use fuzzy return addresses in lock testcases .
Jan 10 2018, 3:36 AM
sconvent created D41896: [OMPT] Use fuzzy return addresses in lock testcases .
Jan 10 2018, 3:32 AM
sconvent updated the diff for D41176: [OMPT] Fix ompt_task_data handling in implicit barriers.

Updated testcase

Jan 10 2018, 2:32 AM
sconvent added inline comments to D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl.
Jan 10 2018, 2:22 AM
sconvent updated the diff for D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl.

Implemented suggestion

Jan 10 2018, 2:20 AM
sconvent updated the diff for D41176: [OMPT] Fix ompt_task_data handling in implicit barriers.

Added Testcase

Jan 10 2018, 1:52 AM

Dec 23 2017

sconvent updated the diff for D41165: [OMPT] Set frame address when creating a task with dependences.

Updated revision

Dec 23 2017, 5:57 AM

Dec 21 2017

sconvent updated the diff for D41171: [OMPT] Handle null pointer in set_callback to improve performance.

Removed unnecessary definition.

Dec 21 2017, 2:14 AM
sconvent updated the diff for D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl.

Implemented suggestion

Dec 21 2017, 1:17 AM

Dec 14 2017

sconvent updated the diff for D41171: [OMPT] Handle null pointer in set_callback to improve performance.

Implemented suggestion

Dec 14 2017, 3:08 AM
sconvent updated the diff for D41171: [OMPT] Handle null pointer in set_callback to improve performance.

Added testcase

Dec 14 2017, 2:50 AM

Dec 13 2017

sconvent updated the diff for D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

Implemented suggestions.

Dec 13 2017, 6:58 AM
sconvent retitled D41182: [OMPT] Add Workaround for Intel Compiler Bug from [ OMPT] Fix testcases for Intel Compiler to [OMPT] Fix testcases for Intel Compiler.
Dec 13 2017, 6:33 AM
sconvent updated subscribers of D41182: [OMPT] Add Workaround for Intel Compiler Bug.
Dec 13 2017, 6:33 AM
sconvent created D41182: [OMPT] Add Workaround for Intel Compiler Bug.
Dec 13 2017, 6:32 AM
sconvent updated the diff for D41181: [OMPT] Fix return address handling in a few GOMP interface methods.

Include another return address handling fix

Dec 13 2017, 6:24 AM
sconvent created D41181: [OMPT] Fix return address handling in a few GOMP interface methods.
Dec 13 2017, 6:12 AM
sconvent updated the diff for D41176: [OMPT] Fix ompt_task_data handling in implicit barriers.

Fixed Diff

Dec 13 2017, 5:27 AM
sconvent created D41176: [OMPT] Fix ompt_task_data handling in implicit barriers.
Dec 13 2017, 5:11 AM
sconvent retitled D41171: [OMPT] Handle null pointer in set_callback to improve performance from Handle null pointer correctly in set_callback to [OMPT] Handle null pointer correctly in set_callback .
Dec 13 2017, 4:56 AM
sconvent created D41171: [OMPT] Handle null pointer in set_callback to improve performance.
Dec 13 2017, 4:54 AM
sconvent updated the diff for D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.

Fix formatting

Dec 13 2017, 4:44 AM
sconvent retitled D41165: [OMPT] Set frame address when creating a task with dependences from Set frame address when creating a task with dependences to [OMPT] Set frame address when creating a task with dependences.
Dec 13 2017, 3:49 AM
sconvent retitled D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl from Move definition of ompt_mutex_impl_t to ompt-internal.h to [OMPT] Move definition of ompt_mutex_impl_t to ompt-internal.h.
Dec 13 2017, 3:49 AM
sconvent retitled D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread from Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread to [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.
Dec 13 2017, 3:49 AM
sconvent created D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.
Dec 13 2017, 3:48 AM
sconvent created D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl.
Dec 13 2017, 3:44 AM
sconvent created D41165: [OMPT] Set frame address when creating a task with dependences.
Dec 13 2017, 3:41 AM
sconvent updated the diff for D40595: [OMPT] Use frames at different level when using clang version 5 or higher with debug flag.

Implemented all suggestions.

Dec 13 2017, 2:45 AM
sconvent added inline comments to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.
Dec 13 2017, 2:19 AM
sconvent updated the diff for D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

The use of UNSUPPORTED seems to be necessary. I updated the Diff.

Dec 13 2017, 2:17 AM

Nov 29 2017

sconvent added a comment to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

@omalyshe Which version of icc introduced the ident information for workshare constructs?

ICC with the ident information has not been released yet

In that case cancel/cancel_worksharing.c should fail for icc-17, icc-18 too?

Nov 29 2017, 7:06 AM