This is an archive of the discontinued LLVM Phabricator instance.

Differential D46206

[clang-tidy] Add Apple prefix acronyms to objc-property-declaration
ClosedPublic

Authored by benhamilton on Apr 27 2018, 12:48 PM.

Details

Reviewers
Wizard
hokein
Commits
rGd4fb951ce353: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration
rCTE331267: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration
rL331267: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration
Summary

This adds a few common Apple first-party API prefixes as acronyms to
objc-property-declaration.

Here's a list showing where these come from:

http://nshipster.com/namespacing/

Test Plan: New tests added. Ran tests with:

% make -j16 check-clang-tools

Diff Detail

Repository
rL LLVM

Event Timeline

benhamilton created this revision.Apr 27 2018, 12:48 PM
Herald added subscribers: cfe-commits, xazax.hun, klimek. · View Herald TranscriptApr 27 2018, 12:48 PM
Harbormaster completed remote builds in B17505: Diff 144387.Apr 27 2018, 12:49 PM
Wizard accepted this revision.Apr 28 2018, 3:26 PM
This revision is now accepted and ready to land.Apr 28 2018, 3:26 PM
Closed by commit rL331267: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration (authored by benhamilton). · Explain WhyMay 1 2018, 7:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 1 2018, 7:52 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clang-tidy/
objc/
8 lines
test/
clang-tidy/
2 lines

Diff 144720

clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.cpp

Show All 39 Lines
/// Keep this list sorted. /// Keep this list sorted.
constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = { constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
"[2-9]G", "[2-9]G",
"ACL", "ACL",
"API", "API",
"ARGB", "ARGB",
"ASCII", "ASCII",
"BGRA", "BGRA",
"CA",
"CF",
"CG",
"CI",
"CV",
"CMYK", "CMYK",
"DNS", "DNS",
"FPS", "FPS",
"FTP", "FTP",
"GIF", "GIF",
"GL",
"GPS", "GPS",
"GUID", "GUID",
"HD", "HD",
"HDR", "HDR",
"HTML", "HTML",
"HTTP", "HTTP",
"HTTPS", "HTTPS",
"HUD", "HUD",
"ID", "ID",
"JPG", "JPG",
"JS", "JS",
"LAN", "LAN",
"LZW", "LZW",
"MDNS", "MDNS",
"MIDI", "MIDI",
"NS",
"OS", "OS",
"PDF", "PDF",
"PIN", "PIN",
"PNG", "PNG",
"POI", "POI",
"PSTN", "PSTN",
"PTR", "PTR",
"QA", "QA",
"QOS", "QOS",
"RGB", "RGB",
"RGBA", "RGBA",
"RGBX", "RGBX",
"ROM", "ROM",
"RPC", "RPC",
"RTF", "RTF",
"RTL", "RTL",
"SC",
"SDK", "SDK",
"SSO", "SSO",
"TCP", "TCP",
"TIFF", "TIFF",
"TTS", "TTS",
"UI", "UI",
"URI", "URI",
"URL", "URL",
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines

clang-tools-extra/trunk/test/clang-tidy/objc-property-declaration.m

Show All 13 Lines
@property(strong, nonatomic) UIViewController *notificationsVC; @property(strong, nonatomic) UIViewController *notificationsVC;
@property(strong, nonatomic) NSString *URL_string; @property(strong, nonatomic) NSString *URL_string;
// CHECK-MESSAGES: :[[@LINE-1]]:40: warning: property name 'URL_string' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:40: warning: property name 'URL_string' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
@property(strong, nonatomic) NSString *supportURLsCamelCase; @property(strong, nonatomic) NSString *supportURLsCamelCase;
@property(strong, nonatomic) NSString *supportURLCamelCase; @property(strong, nonatomic) NSString *supportURLCamelCase;
@property(strong, nonatomic) NSString *VCsPluralToAdd; @property(strong, nonatomic) NSString *VCsPluralToAdd;
@property(assign, nonatomic) int centerX; @property(assign, nonatomic) int centerX;
@property(assign, nonatomic) int enable2GBackgroundFetch; @property(assign, nonatomic) int enable2GBackgroundFetch;
@property(assign, nonatomic) int shouldUseCFPreferences;
@property(assign, nonatomic) int enableGLAcceleration;
@end @end
@interface Foo (Bar) @interface Foo (Bar)
@property(assign, nonatomic) int abc_NotCamelCase; @property(assign, nonatomic) int abc_NotCamelCase;
// CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abc_NotCamelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abc_NotCamelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
@property(assign, nonatomic) int abCD_camelCase; @property(assign, nonatomic) int abCD_camelCase;
// CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abCD_camelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abCD_camelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
// CHECK-FIXES: @property(assign, nonatomic) int abcd_camelCase; // CHECK-FIXES: @property(assign, nonatomic) int abcd_camelCase;
@property(assign, nonatomic) int abCD_NotCamelCase; @property(assign, nonatomic) int abCD_NotCamelCase;
// CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abCD_NotCamelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abCD_NotCamelCase' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
// CHECK-FIXES: @property(assign, nonatomic) int abcd_notCamelCase; // CHECK-FIXES: @property(assign, nonatomic) int abcd_notCamelCase;
@property(assign, nonatomic) int wrongFormat_; @property(assign, nonatomic) int wrongFormat_;
// CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'wrongFormat_' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'wrongFormat_' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
@property(strong, nonatomic) NSString *URLStr; @property(strong, nonatomic) NSString *URLStr;
@property(assign, nonatomic) int abc_camelCase; @property(assign, nonatomic) int abc_camelCase;
@end @end
@interface Foo () @interface Foo ()
@property(assign, nonatomic) int abc_inClassExtension; @property(assign, nonatomic) int abc_inClassExtension;
// CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abc_inClassExtension' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration] // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: property name 'abc_inClassExtension' not using lowerCamelCase style or not prefixed in a category, according to the Apple Coding Guidelines [objc-property-declaration]
@end @end
No newline at end of file No newline at end of file