This is an archive of the discontinued LLVM Phabricator instance.

Differential D45912

update test to use ivar in implementation instead of class extension
ClosedPublic

Authored by Wizard on Apr 20 2018, 5:33 PM.

Details

Reviewers
alexfh
hokein
Commits
rG004b6c684219: update test to use ivar in implementation instead of class extension
rCTE330559: update test to use ivar in implementation instead of class extension
rL330559: update test to use ivar in implementation instead of class extension
Summary

using ivar in class extension is not supported in 32-bit architecture of MacOS.

Diff Detail

Event Timeline

Wizard created this revision.Apr 20 2018, 5:33 PM
Herald added subscribers: cfe-commits, klimek. · View Herald TranscriptApr 20 2018, 5:33 PM
Wizard edited the summary of this revision. (Show Details)Apr 20 2018, 5:34 PM
Wizard added reviewers: alexfh, hokein.
alexfh accepted this revision.Apr 20 2018, 10:51 PM

LG

This revision is now accepted and ready to land.Apr 20 2018, 10:51 PM
Wizard updated this revision to Diff 143494.Apr 22 2018, 5:12 PM

add back objc update for identifier naming check.

Harbormaster completed remote builds in B17315: Diff 143494.Apr 22 2018, 5:14 PM
Closed by commit rL330559: update test to use ivar in implementation instead of class extension (authored by Wizard). · Explain WhyApr 22 2018, 5:18 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 22 2018, 5:18 PM

Revision Contents

PathSize
test/
clang-tidy/
2 lines

Diff 143421

test/clang-tidy/readability-identifier-naming-objc.m

// RUN: %check_clang_tidy %s readability-identifier-naming %t \ // RUN: %check_clang_tidy %s readability-identifier-naming %t \
// RUN: -config='{CheckOptions: \ // RUN: -config='{CheckOptions: \
// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ // RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \
// RUN: -- // RUN: --
@interface Foo @interface Foo
@end @end
@interface Foo () { @implementation Foo {
int _bar; int _bar;
int barWithoutPrefix; int barWithoutPrefix;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for objc ivar 'barWithoutPrefix' [readability-identifier-naming] // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for objc ivar 'barWithoutPrefix' [readability-identifier-naming]
// CHECK-FIXES: int _barWithoutPrefix; // CHECK-FIXES: int _barWithoutPrefix;
} }
@end @end