Page MenuHomePhabricator

add more "anchors"
Needs ReviewPublic

Authored by weimingz on Apr 20 2018, 11:21 AM.

Details

Reviewers
dblaikie
Summary

add more missing "anchors" by using -Wweak-vtable.

Diff Detail

Event Timeline

weimingz created this revision.Apr 20 2018, 11:21 AM

I'd say if we can't actually get it totally clean & enable the warning, maybe it's not worth doing all this? & you (& others in your situation) can contribute patches on an as-needed basis?

Though I don't mind too much having these committed.

include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
160

This isn't an anchor, though, since it's defined in-line?

include/llvm/MC/MCSubtargetInfo.h
178

Probably make this private as you've done in other cases.

lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
547

Take it this caused some link problems/layering violations?

weimingz updated this revision to Diff 143431.Apr 20 2018, 11:03 PM

maybe we can apply the -Wweak-vtable flag lib by lib. does the CMakeList support it?

lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
547

This "anchor" is not needed. I forgot to remove it. Thanks for catching it.

(the fact that phabricator just ignores some mails is annoying)

maybe we can apply the -Wweak-vtable flag lib by lib. does the CMakeList support it?

Already replied via mail: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180416/544528.html