This is an archive of the discontinued LLVM Phabricator instance.

Differential D45795

Match llvm-side change to reloc section header
ClosedPublic

Authored by sbc100 on Apr 18 2018, 8:41 PM.

Details

Reviewers
ncw
Commits
rG1bfdabacfeb6: [WebAssembly] Match llvm-side change to reloc section header
rL330750: [WebAssembly] Match llvm-side change to reloc section header
rLLD330750: [WebAssembly] Match llvm-side change to reloc section header

Diff Detail

Event Timeline

sbc100 created this revision.Apr 18 2018, 8:41 PM
Herald added subscribers: llvm-commits, aheejin. · View Herald TranscriptApr 18 2018, 8:41 PM
Harbormaster completed remote builds in B17202: Diff 143037.Apr 18 2018, 8:43 PM
ncw accepted this revision.Apr 24 2018, 10:37 AM
This revision is now accepted and ready to land.Apr 24 2018, 10:37 AM
Closed by commit rLLD330750: [WebAssembly] Match llvm-side change to reloc section header (authored by sbc). · Explain WhyApr 24 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.
yurydelendik mentioned this in D45118: [WebAssembly] Linking debug (DWARF) sections from WebAssembly object files.Apr 25 2018, 5:57 PM

Revision Contents

PathSize
wasm/
2 lines

Diff 143037

wasm/Writer.cpp

Show First 20 Lines • Show All 374 Lines • ▼ Show 20 Lines if (OSec->Type == WASM_SEC_DATA)
Name = "reloc.DATA"; Name = "reloc.DATA";
else if (OSec->Type == WASM_SEC_CODE) else if (OSec->Type == WASM_SEC_CODE)
Name = "reloc.CODE"; Name = "reloc.CODE";
else else
llvm_unreachable("relocations only supported for code and data"); llvm_unreachable("relocations only supported for code and data");
SyntheticSection *Section = createSyntheticSection(WASM_SEC_CUSTOM, Name); SyntheticSection *Section = createSyntheticSection(WASM_SEC_CUSTOM, Name);
raw_ostream &OS = Section->getStream(); raw_ostream &OS = Section->getStream();
writeUleb128(OS, OSec->Type, "reloc section"); writeUleb128(OS, i, "reloc section");
writeUleb128(OS, Count, "reloc count"); writeUleb128(OS, Count, "reloc count");
OSec->writeRelocations(OS); OSec->writeRelocations(OS);
} }
} }
static uint32_t getWasmFlags(const Symbol *Sym) { static uint32_t getWasmFlags(const Symbol *Sym) {
uint32_t Flags = 0; uint32_t Flags = 0;
if (Sym->isLocal()) if (Sym->isLocal())
▲ Show 20 Lines • Show All 626 Lines • Show Last 20 Lines