This is an archive of the discontinued LLVM Phabricator instance.

[UnitTests] NFC/build-perf: Break up nontrivial compile jobs
ClosedPublic

Authored by davezarzycki on Apr 18 2018, 10:18 AM.

Details

Summary

RecursiveASTVisitorTest.cpp is one of the longest compile jobs and a build bottleneck on many-core machines. This patch breaks that file and some peer files up into smaller files to increase build concurrency and overall rebuild performance.

Diff Detail

Repository
rC Clang

Event Timeline

davezarzycki created this revision.Apr 18 2018, 10:18 AM

Ping. Any review feedback would be appreciated. Thanks!

thakis accepted this revision.Apr 19 2018, 10:25 AM
thakis added a subscriber: thakis.

Makes sense to me.

This revision is now accepted and ready to land.Apr 19 2018, 10:25 AM
davezarzycki closed this revision.Apr 19 2018, 11:24 AM

Thanks @thakis!

Committed as r330353

Tooling/CMakeLists.txt