This is an archive of the discontinued LLVM Phabricator instance.

Differential D45769

Fix typo in static_assert for size of LoadSDNodeBitfields.
ClosedPublic

Authored by paulwalker-arm on Apr 18 2018, 6:30 AM.

Details

Reviewers
fhahn
jlebar
delena
RKSimon
Commits
rGf6e44a0bdffd: Fix typo in static_assert for size of LoadSDNodeBitfields.
rL330830: Fix typo in static_assert for size of LoadSDNodeBitfields.

Diff Detail

Event Timeline

paulwalker-arm created this revision.Apr 18 2018, 6:30 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 18 2018, 6:30 AM
fhahn accepted this revision.Apr 20 2018, 9:51 AM
fhahn added reviewers: jlebar, delena, RKSimon.

Thanks, LGTM. Please wait with committing a bit, in case anyone else wants to chime in.

This revision is now accepted and ready to land.Apr 20 2018, 9:51 AM
jlebar added a comment.Apr 20 2018, 12:00 PM

Yikes.

Nice catch.

jlebar accepted this revision.Apr 20 2018, 12:00 PM
Closed by commit rL330830: Fix typo in static_assert for size of LoadSDNodeBitfields. (authored by pwalker). · Explain WhyApr 25 2018, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
CodeGen/
2 lines

Diff 142924

include/llvm/CodeGen/SelectionDAGNodes.h

Show First 20 Lines • Show All 538 Lines • ▼ Show 20 Linesprotected:
// RawSDNodeBits must cover the entirety of the union. This means that all of // RawSDNodeBits must cover the entirety of the union. This means that all of
// the union's members must have size <= RawSDNodeBits. We write the RHS as // the union's members must have size <= RawSDNodeBits. We write the RHS as
// "2" instead of sizeof(RawSDNodeBits) because MSVC can't handle the latter. // "2" instead of sizeof(RawSDNodeBits) because MSVC can't handle the latter.
static_assert(sizeof(SDNodeBitfields) <= 2, "field too wide"); static_assert(sizeof(SDNodeBitfields) <= 2, "field too wide");
static_assert(sizeof(ConstantSDNodeBitfields) <= 2, "field too wide"); static_assert(sizeof(ConstantSDNodeBitfields) <= 2, "field too wide");
static_assert(sizeof(MemSDNodeBitfields) <= 2, "field too wide"); static_assert(sizeof(MemSDNodeBitfields) <= 2, "field too wide");
static_assert(sizeof(LSBaseSDNodeBitfields) <= 2, "field too wide"); static_assert(sizeof(LSBaseSDNodeBitfields) <= 2, "field too wide");
static_assert(sizeof(LoadSDNodeBitfields) <= 4, "field too wide"); static_assert(sizeof(LoadSDNodeBitfields) <= 2, "field too wide");
static_assert(sizeof(StoreSDNodeBitfields) <= 2, "field too wide"); static_assert(sizeof(StoreSDNodeBitfields) <= 2, "field too wide");
private: private:
friend class SelectionDAG; friend class SelectionDAG;
// TODO: unfriend HandleSDNode once we fix its operand handling. // TODO: unfriend HandleSDNode once we fix its operand handling.
friend class HandleSDNode; friend class HandleSDNode;
/// Unique id per SDNode in the DAG. /// Unique id per SDNode in the DAG.
▲ Show 20 Lines • Show All 1,844 Lines • Show Last 20 Lines