Page MenuHomePhabricator

[NEON] Fix the architecture condition for the crypto intrinsics
ClosedPublic

Authored by kosarev on Apr 15 2018, 6:11 AM.

Details

Summary

This is rather a cosmetic change as on ARMv7 targets we do not define __ARM_FEATURE_CRYPTO, even if it was explicitly requested with -target-feature. The crypto intrinsics test cases are in tools/clang/test/CodeGen/neon-crypto.c . No changes are necessary for them.

Diff Detail

Repository
rL LLVM

Event Timeline

kosarev created this revision.Apr 15 2018, 6:11 AM
SjoerdMeijer accepted this revision.Apr 16 2018, 5:22 AM

This looks correct to me, the ACLE indeed says that:

This is only available when __ARM_ARCH >= 8

Thanks for fixing this.

This revision is now accepted and ready to land.Apr 16 2018, 5:22 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.