This is an archive of the discontinued LLVM Phabricator instance.

Add PPC64_GLINK dynamic tag
ClosedPublic

Authored by sfertile on Apr 12 2018, 8:57 AM.

Details

Summary

Adds support for the PPC64_GLINK dynamic tag which is used in the ElfV2 abi.

Diff Detail

Repository
rL LLVM

Event Timeline

sfertile created this revision.Apr 12 2018, 8:57 AM

LGTM other than adding a gap between MIPS tags and PPC tags

include/llvm/BinaryFormat/DynamicTags.def
178

I would add a newline and a // PPC specific dynamic table entries comment

191

Good catch, I forgot to add those in my initial change.

sfertile added inline comments.Apr 12 2018, 2:15 PM
include/llvm/BinaryFormat/DynamicTags.def
178

Will do, thanks.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.